[librsvg: 6/7] element: provide default empty set_atts



commit 52dbb8098fa4a2c0740ad320973bdf861688a163
Author: Paolo Borelli <pborelli gnome org>
Date:   Sat Mar 28 13:05:03 2020 +0100

    element: provide default empty set_atts

 rsvg_internals/src/element.rs   |  4 +++-
 rsvg_internals/src/structure.rs | 14 +-------------
 2 files changed, 4 insertions(+), 14 deletions(-)
---
diff --git a/rsvg_internals/src/element.rs b/rsvg_internals/src/element.rs
index de50e47e..efffe4b8 100644
--- a/rsvg_internals/src/element.rs
+++ b/rsvg_internals/src/element.rs
@@ -138,7 +138,9 @@ pub trait ElementTrait: Downcast {
     /// Sets per-element attributes from the `pbag`
     ///
     /// Each element is supposed to iterate the `pbag`, and parse any attributes it needs.
-    fn set_atts(&mut self, pbag: &PropertyBag<'_>) -> ElementResult;
+    fn set_atts(&mut self, _pbag: &PropertyBag<'_>) -> ElementResult {
+        Ok(())
+    }
 
     /// Sets any special-cased properties that the element may have, that are different
     /// from defaults in the element's `SpecifiedValues`.
diff --git a/rsvg_internals/src/structure.rs b/rsvg_internals/src/structure.rs
index 16363ba3..1d13a56b 100644
--- a/rsvg_internals/src/structure.rs
+++ b/rsvg_internals/src/structure.rs
@@ -23,10 +23,6 @@ use crate::viewbox::*;
 pub struct Group();
 
 impl ElementTrait for Group {
-    fn set_atts(&mut self, _: &PropertyBag<'_>) -> ElementResult {
-        Ok(())
-    }
-
     fn draw(
         &self,
         node: &Node,
@@ -50,20 +46,12 @@ impl ElementTrait for Group {
 #[derive(Default)]
 pub struct NonRendering;
 
-impl ElementTrait for NonRendering {
-    fn set_atts(&mut self, _: &PropertyBag<'_>) -> ElementResult {
-        Ok(())
-    }
-}
+impl ElementTrait for NonRendering {}
 
 #[derive(Default)]
 pub struct Switch();
 
 impl ElementTrait for Switch {
-    fn set_atts(&mut self, _: &PropertyBag<'_>) -> ElementResult {
-        Ok(())
-    }
-
     fn draw(
         &self,
         node: &Node,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]