[gnome-control-center/gnome-3-36] sharing: Set label for checkbox properly



commit 105b60d2a6fc72d74ea6a6e7248f0f5e16e73e5f
Author: António Fernandes <antoniojpfernandes gmail com>
Date:   Mon Mar 30 15:37:03 2020 +0000

    sharing: Set label for checkbox properly
    
    The Screen Sharing dialog used to have a switch, which was changed to a
    checkbox in 8b689614315089781e604b8e76521c1e926bbdac
    
    However, unlike switches, checkboxes are expected to have clicable labels
    
    Let's set the label properly, instead of doing it the switch way.
    
    Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/565
    
    
    (cherry picked from commit cde8f69ad69c0759f2ddba1ce321c8e4d6cd794b)

 panels/sharing/cc-sharing-panel.ui | 36 ++++++------------------------------
 1 file changed, 6 insertions(+), 30 deletions(-)
---
diff --git a/panels/sharing/cc-sharing-panel.ui b/panels/sharing/cc-sharing-panel.ui
index d9e0d08b2..eb13c8fee 100644
--- a/panels/sharing/cc-sharing-panel.ui
+++ b/panels/sharing/cc-sharing-panel.ui
@@ -562,37 +562,13 @@
                     <property name="orientation">vertical</property>
                     <property name="spacing">12</property>
                     <child>
-                      <object class="GtkBox" id="box6">
+                      <object class="GtkCheckButton" id="remote_control_checkbutton">
                         <property name="visible">True</property>
-                        <property name="can_focus">False</property>
-                        <property name="spacing">6</property>
-                        <child>
-                          <object class="GtkLabel" id="remote_control_label">
-                            <property name="visible">True</property>
-                            <property name="can_focus">False</property>
-                            <property name="halign">start</property>
-                            <property name="hexpand">True</property>
-                            <property name="label" translatable="yes">_Allow connections to control the 
screen</property>
-                            <property name="use_underline">True</property>
-                            <property name="mnemonic_widget">remote_control_checkbutton</property>
-                          </object>
-                          <packing>
-                            <property name="expand">False</property>
-                            <property name="fill">True</property>
-                            <property name="position">1</property>
-                          </packing>
-                        </child>
-                        <child>
-                          <object class="GtkCheckButton" id="remote_control_checkbutton">
-                            <property name="visible">True</property>
-                            <property name="can_focus">True</property>
-                          </object>
-                          <packing>
-                            <property name="expand">False</property>
-                            <property name="fill">True</property>
-                            <property name="position">0</property>
-                          </packing>
-                        </child>
+                        <property name="can_focus">True</property>
+                        <property name="receives_default">False</property>
+                        <property name="draw_indicator">True</property>
+                        <property name="use_underline">True</property>
+                        <property name="label" translatable="yes">_Allow connections to control the 
screen</property>
                       </object>
                       <packing>
                         <property name="expand">False</property>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]