[gtk/wip/hadess/portal-fixes: 3/5] colorpickerportal: Don't throw warnings on missing version



commit 58239344e721e3b564856dbe42b8894e14c1ba2d
Author: Bastien Nocera <hadess hadess net>
Date:   Mon Mar 23 14:48:00 2020 +0100

    colorpickerportal: Don't throw warnings on missing version
    
    If the version can't be fetched, don't throw a warning.

 gtk/gtkcolorpickerportal.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/gtk/gtkcolorpickerportal.c b/gtk/gtkcolorpickerportal.c
index 85e5f7c04e..352a35f8b5 100644
--- a/gtk/gtkcolorpickerportal.c
+++ b/gtk/gtkcolorpickerportal.c
@@ -51,7 +51,7 @@ gtk_color_picker_portal_initable_init (GInitable     *initable,
   GtkColorPickerPortal *picker = GTK_COLOR_PICKER_PORTAL (initable);
   g_autofree char *owner = NULL;
   g_autoptr(GVariant) ret = NULL;
-  guint version;
+  guint version = 0;
 
   if (!gdk_should_use_portal ())
     return FALSE;
@@ -80,7 +80,9 @@ gtk_color_picker_portal_initable_init (GInitable     *initable,
     }
 
   ret = g_dbus_proxy_get_cached_property (picker->portal_proxy, "version");
-  version = g_variant_get_uint32 (ret);
+  if (ret)
+    version = g_variant_get_uint32 (ret);
+
   if (version != 2)
     {
       g_debug ("Screenshot portal version: %u", version);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]