[epiphany/mcatanzaro/app-mode-fixes: 1/3] Fix invalid free in ephy_web_application_setup_from_desktop_file()



commit 21bfda2de1cad9572296e288ac5423d7510155ab
Author: Michael Catanzaro <mcatanzaro gnome org>
Date:   Thu Mar 26 13:36:49 2020 -0500

    Fix invalid free in ephy_web_application_setup_from_desktop_file()
    
    We are clobbering the GDesktopAppInfo's internal icon here, leading to a
    critical later when it gets finalized.
    
    Note: this function is only called when a desktop file basename is
    passed to --application-mode. Epiphany will never create such web apps
    itself, which is how this went unnoticed for so long, but it's used by
    fedora-developer-portal (prior to F32, which switched to Chromium
    instead of Epiphany at my request).

 lib/ephy-web-app-utils.c | 1 -
 1 file changed, 1 deletion(-)
---
diff --git a/lib/ephy-web-app-utils.c b/lib/ephy-web-app-utils.c
index 18f165a03..10b30ae20 100644
--- a/lib/ephy-web-app-utils.c
+++ b/lib/ephy-web-app-utils.c
@@ -510,7 +510,6 @@ ephy_web_application_setup_from_desktop_file (GDesktopAppInfo *desktop_info)
     if (names)
       gtk_window_set_default_icon_name (names[0]);
   }
-  g_clear_object (&icon);
 
   /* We need to re-set this because we have already parsed the
    * options, which inits GTK+ and sets this as a side effect.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]