[gnome-applets/window-picker-module: 1/2] windowpicker: fix regression in wp_applet_load



commit d44aac51ab5757632bee570b7619ea8987e2b7d7
Author: Sebastian Geiger <sbastig gmx net>
Date:   Sat Mar 21 23:38:07 2020 +0100

    windowpicker: fix regression in wp_applet_load
    
    In commit daaaa96621d7518dd63f960861e1f810d0f4dbb7 we moved the setup
    functions from wp_applet_init to wp_applet_load which introduced a
    regession since g_settings_bind is now called with an uninitialized
    applet title.

 windowpicker/src/wp-applet.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/windowpicker/src/wp-applet.c b/windowpicker/src/wp-applet.c
index 0d1bec705..e797e99bd 100644
--- a/windowpicker/src/wp-applet.c
+++ b/windowpicker/src/wp-applet.c
@@ -207,6 +207,11 @@ wp_applet_load (PanelApplet *panel_applet)
 
   applet = WP_APPLET (panel_applet);
 
+  wp_applet_setup_list (applet);
+  wp_applet_setup_title (applet);
+
+  wp_applet_setup_menu (panel_applet);
+
   applet->settings = panel_applet_settings_new (panel_applet, SETTINGS_SCHEMA);
 
   g_settings_bind (applet->settings, KEY_SHOW_ALL_WINDOWS,
@@ -223,11 +228,6 @@ wp_applet_load (PanelApplet *panel_applet)
   g_settings_bind (applet->settings, KEY_ICONS_GREYSCALE,
                    applet, KEY_ICONS_GREYSCALE, G_SETTINGS_BIND_GET);
 
-  wp_applet_setup_list (applet);
-  wp_applet_setup_title (applet);
-
-  wp_applet_setup_menu (panel_applet);
-
   gtk_widget_show_all (GTK_WIDGET (applet));
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]