[gimp/wip/Jehan/make-check-CI-master] Just for the test!



commit a727d2a510ab60db05e7cebc66c33765250c2d2d
Author: Jehan <jehan girinstud io>
Date:   Thu Mar 19 11:19:18 2020 +0100

    Just for the test!
    
    I could confirm the issue happens in gimp_exit()?
    This is extra ugly to debug with printf in the CI, but since I can't
    reproduce and am stuck, let's do the ugly approach!

 app/app.c                       | 2 +-
 app/core/gimp-data-factories.c  | 1 +
 app/core/gimp-modules.c         | 2 ++
 app/core/gimp-parasites.c       | 1 +
 app/core/gimp-templates.c       | 1 +
 app/core/gimp-units.c           | 1 +
 app/core/gimp.c                 | 8 ++++++--
 app/core/gimpextensionmanager.c | 2 ++
 app/gui/gui.c                   | 4 ++--
 app/plug-in/gimppluginmanager.c | 1 +
 10 files changed, 18 insertions(+), 5 deletions(-)
---
diff --git a/app/app.c b/app/app.c
index 903aacbb24..d0455965a2 100644
--- a/app/app.c
+++ b/app/app.c
@@ -490,7 +490,7 @@ app_exit_after_callback (Gimp       *gimp,
                          gboolean    kill_it,
                          GMainLoop **loop)
 {
-  if (gimp->be_verbose)
+  /*if (gimp->be_verbose)*/
     g_print ("EXIT: %s\n", G_STRFUNC);
 
   /*
diff --git a/app/core/gimp-data-factories.c b/app/core/gimp-data-factories.c
index ad358f31e4..13fee6a8ed 100644
--- a/app/core/gimp-data-factories.c
+++ b/app/core/gimp-data-factories.c
@@ -423,6 +423,7 @@ gimp_data_factories_load (Gimp               *gimp,
 void
 gimp_data_factories_save (Gimp *gimp)
 {
+  g_print ("EXIT: %s\n", G_STRFUNC);
   g_return_if_fail (GIMP_IS_GIMP (gimp));
 
   gimp_tag_cache_save (gimp->tag_cache);
diff --git a/app/core/gimp-modules.c b/app/core/gimp-modules.c
index 4ab685ac25..c33c8f8c29 100644
--- a/app/core/gimp-modules.c
+++ b/app/core/gimp-modules.c
@@ -172,6 +172,7 @@ add_to_inhibit_string (gpointer data,
 void
 gimp_modules_unload (Gimp *gimp)
 {
+  g_print ("EXIT : %s\n", G_STRFUNC);
   g_return_if_fail (GIMP_IS_GIMP (gimp));
 
   if (! gimp->no_interface && gimp->write_modulerc)
@@ -220,6 +221,7 @@ gimp_modules_unload (Gimp *gimp)
           g_clear_error (&error);
         }
     }
+  g_print ("EXIT DONE: %s\n", G_STRFUNC);
 }
 
 void
diff --git a/app/core/gimp-parasites.c b/app/core/gimp-parasites.c
index 1bf1cc03f9..e36417acc7 100644
--- a/app/core/gimp-parasites.c
+++ b/app/core/gimp-parasites.c
@@ -149,6 +149,7 @@ gimp_parasiterc_save (Gimp *gimp)
   GFile  *file;
   GError *error = NULL;
 
+  g_print ("EXIT: %s\n", G_STRFUNC);
   g_return_if_fail (GIMP_IS_GIMP (gimp));
   g_return_if_fail (GIMP_IS_PARASITE_LIST (gimp->parasites));
 
diff --git a/app/core/gimp-templates.c b/app/core/gimp-templates.c
index 3d0142a1bc..20fb714b72 100644
--- a/app/core/gimp-templates.c
+++ b/app/core/gimp-templates.c
@@ -92,6 +92,7 @@ gimp_templates_save (Gimp *gimp)
   GFile  *file;
   GError *error = NULL;
 
+  g_print ("EXIT: %s\n", G_STRFUNC);
   g_return_if_fail (GIMP_IS_GIMP (gimp));
   g_return_if_fail (GIMP_IS_LIST (gimp->templates));
 
diff --git a/app/core/gimp-units.c b/app/core/gimp-units.c
index 77a4c84f14..7d618af353 100644
--- a/app/core/gimp-units.c
+++ b/app/core/gimp-units.c
@@ -295,6 +295,7 @@ gimp_unitrc_save (Gimp *gimp)
   gint              i;
   GError           *error = NULL;
 
+  g_print ("EXIT: %s\n", G_STRFUNC);
   g_return_if_fail (GIMP_IS_GIMP (gimp));
 
   file = gimp_directory_file ("unitrc", NULL);
diff --git a/app/core/gimp.c b/app/core/gimp.c
index 30dd92a4c3..5c4370be60 100644
--- a/app/core/gimp.c
+++ b/app/core/gimp.c
@@ -572,7 +572,7 @@ static gboolean
 gimp_real_exit (Gimp     *gimp,
                 gboolean  force)
 {
-  if (gimp->be_verbose)
+  /*if (gimp->be_verbose)*/
     g_print ("EXIT: %s\n", G_STRFUNC);
 
   gimp_plug_in_manager_exit (gimp->plug_in_manager);
@@ -585,6 +585,7 @@ gimp_real_exit (Gimp     *gimp,
   gimp_parasiterc_save (gimp);
   gimp_unitrc_save (gimp);
 
+  g_print ("EXIT DONE: %s\n", G_STRFUNC);
   return FALSE; /* continue exiting */
 }
 
@@ -868,12 +869,13 @@ gimp_exit (Gimp     *gimp,
 
   g_return_if_fail (GIMP_IS_GIMP (gimp));
 
-  if (gimp->be_verbose)
+  /*if (gimp->be_verbose)*/
     g_print ("EXIT: %s\n", G_STRFUNC);
 
   g_signal_emit (gimp, gimp_signals[EXIT], 0,
                  force ? TRUE : FALSE,
                  &handled);
+  g_print ("EXIT signal run: %s\n", G_STRFUNC);
 
   if (handled)
     return;
@@ -887,7 +889,9 @@ gimp_exit (Gimp     *gimp,
     {
       GimpImage *image = image_iter->data;
 
+      printf("deleting image %ld\n", image);
       g_object_unref (image);
+      printf("image deleted\n");
     }
 }
 
diff --git a/app/core/gimpextensionmanager.c b/app/core/gimpextensionmanager.c
index e32eab5f17..529e7c0d21 100644
--- a/app/core/gimpextensionmanager.c
+++ b/app/core/gimpextensionmanager.c
@@ -646,6 +646,7 @@ gimp_extension_manager_exit (GimpExtensionManager *manager)
   GFile  *file;
   GError *error = NULL;
 
+  g_print ("EXIT: %s\n", G_STRFUNC);
   g_return_if_fail (GIMP_IS_EXTENSION_MANAGER (manager));
 
   file = gimp_directory_file ("extensionrc", NULL);
@@ -665,6 +666,7 @@ gimp_extension_manager_exit (GimpExtensionManager *manager)
     }
 
   g_object_unref (file);
+  g_print ("EXIT DONE: %s\n", G_STRFUNC);
 }
 
 const GList *
diff --git a/app/gui/gui.c b/app/gui/gui.c
index 734623a440..23e90c5577 100644
--- a/app/gui/gui.c
+++ b/app/gui/gui.c
@@ -711,7 +711,7 @@ gui_exit_callback (Gimp     *gimp,
   GimpGuiConfig *gui_config = GIMP_GUI_CONFIG (gimp->config);
   GimpTool      *active_tool;
 
-  if (gimp->be_verbose)
+  /*if (gimp->be_verbose)*/
     g_print ("EXIT: %s\n", G_STRFUNC);
 
   if (! force && gimp_displays_dirty (gimp))
@@ -777,7 +777,7 @@ static gboolean
 gui_exit_after_callback (Gimp     *gimp,
                          gboolean  force)
 {
-  if (gimp->be_verbose)
+  /*if (gimp->be_verbose)*/
     g_print ("EXIT: %s\n", G_STRFUNC);
 
   g_signal_handlers_disconnect_by_func (gimp->config,
diff --git a/app/plug-in/gimppluginmanager.c b/app/plug-in/gimppluginmanager.c
index d8952a289f..0ef9bdf43b 100644
--- a/app/plug-in/gimppluginmanager.c
+++ b/app/plug-in/gimppluginmanager.c
@@ -264,6 +264,7 @@ gimp_plug_in_manager_exit (GimpPlugInManager *manager)
 {
   g_return_if_fail (GIMP_IS_PLUG_IN_MANAGER (manager));
 
+  g_print ("EXIT: %s\n", G_STRFUNC);
   while (manager->open_plug_ins)
     gimp_plug_in_close (manager->open_plug_ins->data, TRUE);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]