[gedit-plugins] findinfiles: null-terminate the accels[] for app.set_accels_for_action()



commit af14988287228e063b3781ad020dc4a742ebe64d
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Thu Mar 19 13:46:05 2020 +0100

    findinfiles: null-terminate the accels[] for app.set_accels_for_action()
    
    When looking at the generated C code, indeed the array was not
    NULL-terminated! Which resulted in random, non-reproducible crashes.
    
    I think it:
    Fixes https://gitlab.gnome.org/GNOME/gedit-plugins/issues/17

 plugins/findinfiles/plugin.vala | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/plugins/findinfiles/plugin.vala b/plugins/findinfiles/plugin.vala
index f8ecdfb..d831bce 100644
--- a/plugins/findinfiles/plugin.vala
+++ b/plugins/findinfiles/plugin.vala
@@ -159,14 +159,14 @@ public class App : GLib.Object, Gedit.AppActivatable {
         var item = new GLib.MenuItem (_("Find in Files…"), "win.find-in-files");
         menu_ext.append_menu_item (item);
 
-        const string accels[] = { "<Shift><Ctrl>f" };
+        const string accels[] = { "<Shift><Ctrl>f", null };
         app.set_accels_for_action ("win.find-in-files", accels);
     }
 
     public void deactivate () {
         menu_ext.remove_items ();
 
-        const string accels[] = {  };
+        const string accels[] = { null };
         app.set_accels_for_action ("win.find-in-files", accels);
     }
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]