[librsvg: 3/10] css: simplify is_empty



commit 9ff6bac1ce39204e40d77560de0a2a062e5088da
Author: Paolo Borelli <pborelli gnome org>
Date:   Sun Mar 15 19:59:53 2020 +0100

    css: simplify is_empty

 rsvg_internals/src/css.rs | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
---
diff --git a/rsvg_internals/src/css.rs b/rsvg_internals/src/css.rs
index 701832f9..25738692 100644
--- a/rsvg_internals/src/css.rs
+++ b/rsvg_internals/src/css.rs
@@ -546,11 +546,10 @@ impl selectors::Element for RsvgElement {
     /// That is, whether it does not contain any child element or any non-zero-length text node.
     /// See http://dev.w3.org/csswg/selectors-3/#empty-pseudo
     fn is_empty(&self) -> bool {
-        !self.0.has_children()
-            || self
-                .0
-                .children()
-                .all(|child| child.is_chars() && child.borrow_chars().is_empty())
+        // .all() returns true for the empty iterator
+        self.0
+            .children()
+            .all(|child| child.is_chars() && child.borrow_chars().is_empty())
     }
 
     /// Returns whether this element matches `:root`,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]