[gnome-panel] run-dialog: fix -Wsign-compare warnings
- From: Alberts Muktupāvels <muktupavels src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-panel] run-dialog: fix -Wsign-compare warnings
- Date: Sat, 7 Mar 2020 23:27:37 +0000 (UTC)
commit 715ffaae55f188b2ca140d12eae7427ff13065e8
Author: Alberts Muktupāvels <alberts muktupavels gmail com>
Date: Sun Mar 8 00:45:44 2020 +0200
run-dialog: fix -Wsign-compare warnings
gnome-panel/panel-run-dialog.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
---
diff --git a/gnome-panel/panel-run-dialog.c b/gnome-panel/panel-run-dialog.c
index d645d1f17..86cfb6165 100644
--- a/gnome-panel/panel-run-dialog.c
+++ b/gnome-panel/panel-run-dialog.c
@@ -1527,6 +1527,7 @@ entry_event (GtkEditable *entry,
char *nprefix;
char *temp;
int pos, tmp;
+ int text_len;
if (event->type != GDK_KEY_PRESS)
return FALSE;
@@ -1540,6 +1541,8 @@ entry_event (GtkEditable *entry,
PANEL_RUN_ENABLE_COMPLETION_KEY))
return FALSE;
+ text_len = strlen (gtk_entry_get_text (GTK_ENTRY (entry)));
+
/* tab completion */
if (event->keyval == GDK_KEY_Tab) {
gtk_editable_get_selection_bounds (entry, &pos, &tmp);
@@ -1547,7 +1550,7 @@ entry_event (GtkEditable *entry,
if (dialog->completion_started &&
pos != tmp &&
pos != 1 &&
- tmp == strlen (gtk_entry_get_text (GTK_ENTRY (entry)))) {
+ tmp == text_len) {
gtk_editable_select_region (entry, 0, 0);
gtk_editable_set_position (entry, -1);
@@ -1560,12 +1563,12 @@ entry_event (GtkEditable *entry,
if (dialog->completion_started &&
pos != tmp &&
pos != 0 &&
- tmp == strlen (gtk_entry_get_text (GTK_ENTRY (entry)))) {
+ tmp == text_len) {
temp = gtk_editable_get_chars (entry, 0, pos);
prefix = g_strconcat (temp, event->string, NULL);
g_free (temp);
} else if (pos == tmp &&
- tmp == strlen (gtk_entry_get_text (GTK_ENTRY (entry)))) {
+ tmp == text_len) {
prefix = g_strconcat (gtk_entry_get_text (GTK_ENTRY (entry)),
event->string, NULL);
} else {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]