[epiphany/mcatanzaro/#1120: 15/15] Fix crash when closing passwords dialog



commit 16bedd4ef8a231e9d695520514819ea04696a37a
Author: Michael Catanzaro <mcatanzaro gnome org>
Date:   Wed Mar 4 14:16:38 2020 -0600

    Fix crash when closing passwords dialog
    
    It seems I missed another spot in this long string of password manager
    leak fixes. We no longer own the GList passed to populate_model_cb(), so
    we need to copy it here. Follow-up to 2c723ef4 and 0b458c71.
    
    Fixes #1120

 src/passwords-dialog.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/src/passwords-dialog.c b/src/passwords-dialog.c
index 8152a8f4a..7277769f2 100644
--- a/src/passwords-dialog.c
+++ b/src/passwords-dialog.c
@@ -413,7 +413,8 @@ populate_model_cb (GList    *records,
     ephy_data_dialog_set_has_data (EPHY_DATA_DIALOG (dialog), TRUE);
   }
 
-  dialog->records = records;
+  g_assert (!dialog->records);
+  dialog->records = g_list_copy_deep (records, (GCopyFunc)g_object_ref, NULL);
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]