[gnome-games/wip/exalm/gameapd: 7/14] gamepad-view: Use a hashtable for storing input data

[Alexander Mikhaylenko <alexm src gnome org>]

commit 8bc2ee5154d2ed7bc230b91816b8d47a18243ac4
Author: Alexander Mikhaylenko <alexm gnome org>
Date:   Wed Mar 4 19:50:19 2020 +0500

    gamepad-view: Use a hashtable for storing input data
    
    This will help to store offsets for analog sticks later without relying on
    array indices.

 src/ui/gamepad-view.vala | 44 ++++++++++++++++++++++++++++++--------------
 1 file changed, 30 insertions(+), 14 deletions(-)
---
diff --git a/src/ui/gamepad-view.vala b/src/ui/gamepad-view.vala
index 9412b4f3..43595ac6 100644
--- a/src/ui/gamepad-view.vala
+++ b/src/ui/gamepad-view.vala
@@ -1,8 +1,12 @@
 // This file is part of GNOME Games. License: GPL-3.0+.
 
 private class Games.GamepadView : Gtk.DrawingArea {
+       private struct InputState {
+               bool highlight;
+       }
+
        private Rsvg.Handle handle;
-       private bool[] input_highlights;
+       private new HashTable<string, InputState?> input_state;
 
        private GamepadViewConfiguration _configuration;
        public GamepadViewConfiguration configuration {
@@ -30,7 +34,15 @@ private class Games.GamepadView : Gtk.DrawingArea {
                        get_dimensions (out width, out height);
 
                        set_size_request ((int) width, (int) height);
-                       input_highlights = new bool[value.input_paths.length];
+
+                       input_state.foreach_remove (() => true);
+
+                       foreach (var path in configuration.input_paths) {
+                               if (path.path in input_state)
+                                       continue;
+
+                               input_state[path.path] = {};
+                       }
 
                        reset ();
                }
@@ -39,7 +51,7 @@ private class Games.GamepadView : Gtk.DrawingArea {
        construct {
                handle = new Rsvg.Handle ();
                configuration = { "", new GamepadInputPath[0] };
-               input_highlights = {};
+               input_state = new HashTable<string, InputState?> (str_hash, str_equal);
        }
 
        private void get_dimensions (out double width, out double height) {
@@ -58,20 +70,23 @@ private class Games.GamepadView : Gtk.DrawingArea {
        }
 
        public void reset () {
-               for (var i = 0; i < input_highlights.length; ++i)
-                       input_highlights[i] = false;
+               input_state.foreach ((path, state) => {
+                       state.highlight = false;
+               });
 
                queue_draw ();
        }
 
        public bool highlight (GamepadInput input, bool highlight) {
-               for (var i = 0; i < configuration.input_paths.length; ++i) {
-                       if (configuration.input_paths[i].input == input) {
-                               input_highlights[i] = highlight;
-                               queue_draw ();
+               foreach (var path in configuration.input_paths) {
+                       if (input != path.input)
+                               continue;
 
-                               return true;
-                       }
+                       input_state[path.path].highlight = highlight;
+
+                       queue_draw ();
+
+                       return true;
                }
 
                return false;
@@ -102,10 +117,10 @@ private class Games.GamepadView : Gtk.DrawingArea {
        }
 
        private void highlight_gamepad (Cairo.Context context) {
-               for (var i = 0; i < configuration.input_paths.length; ++i)
-                       if (input_highlights[i]) {
+               input_state.for_each ((path, state) => {
+                       if (state.highlight) {
                                context.push_group ();
-                               handle.render_cairo_sub (context, "#" + configuration.input_paths[i].path);
+                               handle.render_cairo_sub (context, @"#$path");
                                var group = context.pop_group ();
 
                                Gdk.RGBA color;
@@ -113,6 +128,7 @@ private class Games.GamepadView : Gtk.DrawingArea {
                                context.set_source_rgba (color.red, color.green, color.blue, color.alpha);
                                context.mask (group);
                        }
+               });
        }
 
        private void calculate_image_dimensions (out double x, out double y, out double scale) {