[gtk/wip/otte/for-master: 1/3] dnd: Fix some documentation gotchas



commit c0a63e6dd2d5c5dfbe0a226d9ba38c82598a452a
Author: Benjamin Otte <otte redhat com>
Date:   Mon Mar 2 21:26:08 2020 +0100

    dnd: Fix some documentation gotchas

 docs/reference/gtk/gtk4-docs.xml |  1 +
 gtk/gtkdroptarget.c              | 20 +++++++++++---------
 2 files changed, 12 insertions(+), 9 deletions(-)
---
diff --git a/docs/reference/gtk/gtk4-docs.xml b/docs/reference/gtk/gtk4-docs.xml
index 732173b671..aabc016df4 100644
--- a/docs/reference/gtk/gtk4-docs.xml
+++ b/docs/reference/gtk/gtk4-docs.xml
@@ -343,6 +343,7 @@
       <xi:include href="xml/gtkdragsource.xml"/>
       <xi:include href="xml/gtkdragicon.xml"/>
       <xi:include href="xml/gtkdroptarget.xml"/>
+      <xi:include href="xml/gtkdroptargetasync.xml"/>
     </chapter>
 
   </part>
diff --git a/gtk/gtkdroptarget.c b/gtk/gtkdroptarget.c
index 3bd86fa93a..093fc0af1f 100644
--- a/gtk/gtkdroptarget.c
+++ b/gtk/gtkdroptarget.c
@@ -45,25 +45,25 @@
  * receive Drag-and-Drop operations.
  *
  * The most basic way to use a #GtkDropTarget to receive drops on a
- * widget, is to create it via gtk_drop_target_new(), passing in the
+ * widget is to create it via gtk_drop_target_new() passing in the
  * #GType of the data you want to receive and connect to the
  * GtkDropTarget::drop signal to receive the data.
  *
  * #GtkDropTarget supports more options, such as:
  *
- *  * rejecting potential drops via the GtkDropTarget::accept signal
+ *  * rejecting potential drops via the #GtkDropTarget::accept signal
  *    and the gtk_drop_target_reject() function to let other drop
  *    targets handle the drop
  *  * tracking an ongoing drag operation before the drop via the
- *    GtkDropTarget::enter, GtkDropTarget::motion and
- *    GtkDropTarget::leave signals
+ *    #GtkDropTarget::enter, #GtkDropTarget::motion and
+ *    #GtkDropTarget::leave signals
  *  * configuring how to receive data by setting the
- *    GtkDropTarget:preload property and listening for its availability
- *    via the GtkDropTarget:value property
+ *    #GtkDropTarget:preload property and listening for its availability
+ *    via the #GtkDropTarget:value property
  *
  * However, #GtkDropTarget is ultimately modeled in a synchronous way
  * and only supports data transferred via #GType.  
- * If you want full control over an ongoing drop, the #GdkDropTargetAsync
+ * If you want full control over an ongoing drop, the #GtkDropTargetAsync
  * object gives you this ability.
  *
  * While a pointer is dragged over the drop target's widget and the drop
@@ -590,11 +590,13 @@ gtk_drop_target_class_init (GtkDropTargetClass *class)
    * huge amounts of data by accident.  
    * For example, if somebody drags a full document of gigabytes of text
    * from a text editor across a widget with a preloading drop target,
-   * this data will be downlaoded, even if the data is ultimately dropped
+   * this data will be downloaded, even if the data is ultimately dropped
    * elsewhere.
    *
    * For a lot of data formats, the amount of data is very small (like
-   * %GDK_TYPE_RGBA), so enabling this property does not hurt at all.
+   * %GDK_TYPE_RGBA), so enabling this property does not hurt at all.  
+   * And for local-only drag'n'drop operations, no data transfer is done,
+   * so enabling it there is free.
    */
   properties[PROP_PRELOAD] =
        g_param_spec_boolean ("preload",


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]