[gvfs/wip/oholy/udisks2-leaks: 1/2] udisks2: Fix leak when updating fstab volumes
- From: Ondrej Holy <oholy src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gvfs/wip/oholy/udisks2-leaks: 1/2] udisks2: Fix leak when updating fstab volumes
- Date: Mon, 2 Mar 2020 12:32:11 +0000 (UTC)
commit aeb87f863950947a83b2c1257d3938568d290067
Author: Ondrej Holy <oholy redhat com>
Date: Mon Mar 2 09:50:38 2020 +0100
udisks2: Fix leak when updating fstab volumes
`g_list_remove_link` is used when filtering out mountpoints, but the
GList element is not consequently freed. Let's use `g_list_delete_link`
to not leak that element.
https://gitlab.gnome.org/GNOME/gvfs/issues/452
monitor/udisks2/gvfsudisks2volumemonitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/monitor/udisks2/gvfsudisks2volumemonitor.c b/monitor/udisks2/gvfsudisks2volumemonitor.c
index 37c81fcf..b200457d 100644
--- a/monitor/udisks2/gvfsudisks2volumemonitor.c
+++ b/monitor/udisks2/gvfsudisks2volumemonitor.c
@@ -1623,7 +1623,7 @@ update_fstab_volumes (GVfsUDisks2VolumeMonitor *monitor,
have_udisks_volume_for_mount_point (monitor, mount_point) ||
!mount_point_has_device (monitor, mount_point))
{
- new_mount_points = g_list_remove_link (new_mount_points, l);
+ new_mount_points = g_list_delete_link (new_mount_points, l);
g_unix_mount_point_free (mount_point);
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]