[geary: 25/66] Code cleanup for old message detach

[Michael Gratton <mjog src gnome org>]

commit 8ccc0f3d60db5d924137789d39e6d8293abeaa36
Author: Chris Heywood <15127-creywood users noreply gitlab gnome org>
Date:   Thu Jan 9 13:41:02 2020 +0100

    Code cleanup for old message detach
    
    Although this logic will likely be later removed

 .../imap-engine/imap-engine-account-synchronizer.vala    | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)
---
diff --git a/src/engine/imap-engine/imap-engine-account-synchronizer.vala 
b/src/engine/imap-engine/imap-engine-account-synchronizer.vala
index 6fcc583ab..439162493 100644
--- a/src/engine/imap-engine/imap-engine-account-synchronizer.vala
+++ b/src/engine/imap-engine/imap-engine-account-synchronizer.vala
@@ -67,14 +67,16 @@ private class Geary.ImapEngine.AccountSynchronizer :
                 !folder.properties.is_local_only &&
                 !folder.properties.is_virtual) {
 
-                AccountOperation op = became_available
-                    ? new CheckFolderSync(
+                AccountOperation op;
+                if (became_available) {
+                    CheckFolderSync check_op = new CheckFolderSync(
                         this.account, imap_folder, this.max_epoch
-                    )
-                    : new RefreshFolderSync(this.account, imap_folder);
-
-                if (became_available)
-                    ((CheckFolderSync) 
op).old_message_detached.connect(this.old_messages_removed_during_sync);
+                    );
+                    check_op.old_message_detached.connect(this.old_messages_removed_during_sync);
+                    op = check_op;
+                } else {
+                    op = new RefreshFolderSync(this.account, imap_folder);
+                }
 
                 try {
                     this.account.queue_operation(op);