[libdmapsharing] Unconditionally include test-*.c in libdmapsharing



commit b7da0e056b29d117f79ad3a3a6be6e42950dce12
Author: W. Michael Petullo <mike flyn org>
Date:   Mon Jun 29 15:14:15 2020 -0500

    Unconditionally include test-*.c in libdmapsharing
    
    These files used to be guarded by HAVE_CHECK. However, test-dmap-client.c
    and test-dmap-server.c require them. Thus we now build them into
    libdmapsharing unconditionally. Perhaps the name should involve
    "reference" rather than "test," and perhaps these could be made a little
    more useful in the general case.
    
    Closes #10.
    Closes #13.

 TODO                       | 2 ++
 libdmapsharing/Makefile.am | 7 +++++--
 2 files changed, 7 insertions(+), 2 deletions(-)
---
diff --git a/TODO b/TODO
index 70c32e7..73027b6 100644
--- a/TODO
+++ b/TODO
@@ -1,5 +1,7 @@
 = Short term ===================================================================
 
+See notes about test-* in libdmapsharing/Makefile.am.
+
 GNOME Bugs:
        344616: support database updates
        686220: play nicely with firewalld
diff --git a/libdmapsharing/Makefile.am b/libdmapsharing/Makefile.am
index 776dde9..e2dc51e 100644
--- a/libdmapsharing/Makefile.am
+++ b/libdmapsharing/Makefile.am
@@ -26,7 +26,11 @@ libdmapsharing_4_0_la_SOURCES = \
        dmap-image-record.c \
        dmap-image-share.c
 
-if HAVE_CHECK
+# These used to be guarded by HAVE_CHECK. However, test-dmap-client.c
+# and test-dmap-server.c require them. Thus we now build them into
+# libdmapsharing unconditionally. Perhaps the name should involve
+# "reference" rather than "test," and perhaps these could be made
+# a little more useful in the general case.
 libdmapsharing_4_0_la_SOURCES += \
        test-dmap-av-record.c \
        test-dmap-av-record-factory.c \
@@ -35,7 +39,6 @@ libdmapsharing_4_0_la_SOURCES += \
        test-dmap-db.c \
        test-dmap-image-record.c \
        test-dmap-image-record-factory.c
-endif
 
 if USE_HOWL
 libdmapsharing_4_0_la_SOURCES += \


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]