[gnome-builder] codespell: delimit codespell messages by line
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder] codespell: delimit codespell messages by line
- Date: Sun, 28 Jun 2020 17:35:36 +0000 (UTC)
commit 3a571ff0e485c57545cdc07e11aacb43af937cff
Author: Günther Wagner <info gunibert de>
Date: Sun Jun 28 14:06:18 2020 +0200
codespell: delimit codespell messages by line
src/plugins/codespell/ide-codespell-diagnostic-provider.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
---
diff --git a/src/plugins/codespell/ide-codespell-diagnostic-provider.c
b/src/plugins/codespell/ide-codespell-diagnostic-provider.c
index 84639d3d7..0cfbc8761 100644
--- a/src/plugins/codespell/ide-codespell-diagnostic-provider.c
+++ b/src/plugins/codespell/ide-codespell-diagnostic-provider.c
@@ -90,6 +90,8 @@ ide_codespell_diagnostic_provider_communicate_cb (GObject *object,
g_autoptr(IdeLocation) loc_end = NULL;
guint64 lineno;
+ line[len] = '\0';
+
/* Lines that we want to parse should look something like this:
* filename:42: misspelled word ==> correct word
*/
@@ -101,7 +103,7 @@ ide_codespell_diagnostic_provider_communicate_cb (GObject *object,
continue;
lineno = g_ascii_strtoull (line, &line, 10);
- if ((lineno == G_MAXUINT64 && errno == ERANGE) || ((lineno == 0) && errno == EINVAL))
+ if (lineno == G_MAXUINT64 || lineno == 0)
continue;
if (lineno > 0)
lineno--;
@@ -150,12 +152,12 @@ ide_codespell_diagnostic_provider_diagnose_async (IdeDiagnosticProvider *provide
ide_task_set_priority (task, G_PRIORITY_LOW);
ide_task_set_task_data (task, g_object_ref (file), g_object_unref);
- launcher = ide_subprocess_launcher_new (G_SUBPROCESS_FLAGS_STDIN_PIPE |
+ launcher = ide_subprocess_launcher_new (G_SUBPROCESS_FLAGS_STDIN_INHERIT |
G_SUBPROCESS_FLAGS_STDOUT_PIPE |
- G_SUBPROCESS_FLAGS_STDERR_SILENCE);
+ G_SUBPROCESS_FLAGS_STDERR_PIPE);
ide_subprocess_launcher_push_argv (launcher, "codespell");
- ide_subprocess_launcher_push_argv (launcher, "-d");
+ /* ide_subprocess_launcher_push_argv (launcher, "-d"); */
ide_subprocess_launcher_push_argv (launcher, g_file_get_path (file));
/* Spawn the process of fail immediately */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]