[gnome-builder] buildui: properly align tooltips to row
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder] buildui: properly align tooltips to row
- Date: Sat, 27 Jun 2020 20:02:52 +0000 (UTC)
commit b8f87e856493425836683684c2c3b04bc978f9ad
Author: Diego Escalante Urrelo <diegoe gnome org>
Date: Sat Jun 27 03:17:59 2020 -0500
buildui: properly align tooltips to row
Also cleanup `gbp_buildui_pane_diagnostic_tooltip()` so it mimics the
pattern in `plugins/todo` and `libide/tree`.
src/plugins/buildui/gbp-buildui-pane.c | 32 ++++++++++++++++++++------------
1 file changed, 20 insertions(+), 12 deletions(-)
---
diff --git a/src/plugins/buildui/gbp-buildui-pane.c b/src/plugins/buildui/gbp-buildui-pane.c
index cca38ec21..9bd033480 100644
--- a/src/plugins/buildui/gbp-buildui-pane.c
+++ b/src/plugins/buildui/gbp-buildui-pane.c
@@ -438,29 +438,37 @@ gbp_buildui_pane_diagnostic_tooltip (GbpBuilduiPane *self,
GtkTooltip *tooltip,
GtkTreeView *tree_view)
{
+ g_autoptr(GtkTreePath) path = NULL;
GtkTreeModel *model = NULL;
- GtkTreeIter iter;
g_assert (GBP_IS_BUILDUI_PANE (self));
g_assert (GTK_IS_TOOLTIP (tooltip));
g_assert (GTK_IS_TREE_VIEW (tree_view));
- if (gtk_tree_view_get_tooltip_context (tree_view, &x, &y, keyboard_mode, &model, NULL, &iter))
- {
- g_autoptr(IdeDiagnostic) diag = NULL;
+ if (NULL == (model = gtk_tree_view_get_model (tree_view)))
+ return FALSE;
- gtk_tree_model_get (model, &iter,
- COLUMN_DIAGNOSTIC, &diag,
- -1);
+ if (gtk_tree_view_get_path_at_pos (tree_view, x, y, &path, NULL, NULL, NULL))
+ {
+ GtkTreeIter iter;
- if (diag != NULL)
+ if (gtk_tree_model_get_iter (model, &iter, path))
{
- g_autofree gchar *text = ide_diagnostic_get_text_for_display (diag);
+ g_autoptr(IdeDiagnostic) diag = NULL;
- gtk_tooltip_set_text (tooltip, text);
+ gtk_tree_model_get (model, &iter,
+ COLUMN_DIAGNOSTIC, &diag,
+ -1);
- return TRUE;
- }
+ if (diag != NULL)
+ {
+ g_autofree gchar *text = ide_diagnostic_get_text_for_display (diag);
+
+ gtk_tree_view_set_tooltip_row (tree_view, tooltip, path);
+ gtk_tooltip_set_text (tooltip, text);
+ return TRUE;
+ }
+ }
}
return FALSE;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]