[vte/wip/sixels: 71/82] terminal: Always draw ' ' and '\t' spaces, since they can erase images



commit b3cc662b4b17b1eb985003dfd7cfb7c8d9a435f9
Author: Hans Petter Jansson <hpj cl no>
Date:   Wed Jun 24 01:17:44 2020 +0200

    terminal: Always draw ' ' and '\t' spaces, since they can erase images

 src/vte.cc | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
---
diff --git a/src/vte.cc b/src/vte.cc
index f3ffbaca..f5f34810 100644
--- a/src/vte.cc
+++ b/src/vte.cc
@@ -8862,15 +8862,10 @@ Terminal::draw_rows(VteScreen *screen_,
                         nhilite = (nhyperlink && cell->attr.hyperlink_idx == m_hyperlink_hover_idx) ||
                                   (!nhyperlink && regex_match_has_current() && m_match_span.contains(row, 
lcol));
                         if (cell->c == 0 ||
-                                ((cell->c == ' ' || cell->c == '\t') &&  // FIXME '\t' is newly added now, 
double check
-                                 cell->attr.has_none(VTE_ATTR_UNDERLINE_MASK |
-                                                     VTE_ATTR_STRIKETHROUGH_MASK |
-                                                     VTE_ATTR_OVERLINE_MASK) &&
-                                 !nhyperlink &&
-                                 !nhilite) ||
                             cell->attr.fragment() ||
                             cell->attr.invisible()) {
-                                /* Skip empty or fragment cell. */
+                                /* Skip empty or fragment cell, but erase on ' ' and '\t', since
+                                 * it may be overwriting an image. */
                                 lcol++;
                                 continue;
                         }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]