[gnome-shell/gbsneto/custom-icon-positions: 20/27] appDisplay: Ensure icons always are at the correct position

[Georges Basile Stavracas Neto <gbsneto src gnome org>]

commit dd69c46e6571320b61a946a64924bdfedd775dd4
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Tue Jun 23 12:18:56 2020 -0300

    appDisplay: Ensure icons always are at the correct position
    
    When redisplaying, we currently only remove and add icons, but
    never adjust the position of already added icons. If the icon
    position changed, it wouldn't be reflected on the icon grid.
    
    Make sure to move already added icons.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1284

 js/ui/appDisplay.js | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 0b57f07386..551f5a5018 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -333,9 +333,12 @@ var BaseAppView = GObject.registerClass({
             return [page, position];
         };
 
-        addedApps.forEach(icon => {
+        newApps.forEach(icon => {
             const [page, position] = getItemPosition(icon);
-            this._addItem(icon, page, position);
+            if (addedApps.includes(icon))
+                this._addItem(icon, page, position);
+            else if (page !== -1 && position !== -1)
+                this.moveItem(icon, page, position);
         });
 
         this._viewIsReady = true;