[gnome-shell/gbsneto/custom-icon-positions: 23/28] appDisplay: Ensure icons always are at the correct position

[Georges Basile Stavracas Neto <gbsneto src gnome org>]

commit 1470e9ff740372c22c7523e75a50a641f05e572f
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Tue Jun 23 12:18:56 2020 -0300

    appDisplay: Ensure icons always are at the correct position
    
    When redisplaying, we currently only remove and add icons, but
    never adjust the position of already added icons. If the icon
    position changed, it wouldn't be reflected on the icon grid.
    
    Make sure to move already added icons.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1284

 js/ui/appDisplay.js | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 8d6b1f07cf..397f986db3 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -325,9 +325,12 @@ var BaseAppView = GObject.registerClass({
             return [page, position];
         };
 
-        addedApps.forEach(icon => {
+        newApps.forEach(icon => {
             const [page, position] = getItemPosition(icon);
-            this._addItem(icon, page, position);
+            if (addedApps.includes(icon))
+                this._addItem(icon, page, position);
+            else
+                this.moveItem(icon, page, position);
         });
 
         this._viewIsReady = true;