[gnome-shell/gbsneto/random-cleanups-pt2: 3/3] appDisplay: Update folder dialog field before ungrabbing



commit 8f8ecdb9836e984df25b3031292afb5f792291ab
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Wed Jun 24 15:32:27 2020 -0300

    appDisplay: Update folder dialog field before ungrabbing
    
    Noticed while working on customizable folders. Calling GrabHelper.ungrab()
    ends up calling FolderDialog.popdown(), but at this point the '_isOpen'
    field isn't updated yet, so we end up calling popdown() twice.
    
    Update the '_isOpen' field before ungrabbing.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1332

 js/ui/appDisplay.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index ff813f3954..807c43a539 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -1782,8 +1782,8 @@ var AppFolderDialog = GObject.registerClass({
         this._zoomAndFadeOut();
         this._showFolderLabel();
 
-        this._grabHelper.ungrab({ actor: this });
         this._isOpen = false;
+        this._grabHelper.ungrab({ actor: this });
         this.emit('open-state-changed', false);
     }
 });


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]