[gnome-shell/gbsneto/custom-icon-positions: 24/25] appDisplay: Update folder dialog field before ungrabbing
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/gbsneto/custom-icon-positions: 24/25] appDisplay: Update folder dialog field before ungrabbing
- Date: Wed, 24 Jun 2020 19:46:31 +0000 (UTC)
commit e0b48bb1f947802b97a4ceb74a385e9c69905a0c
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date: Wed Jun 24 15:32:27 2020 -0300
appDisplay: Update folder dialog field before ungrabbing
Noticed while working on customizable folders. Calling GrabHelper.ungrab()
ends up calling FolderDialog.popdown(), but at this poind the '_isOpen'
field isn't updated yet, so we end up calling popdown() twice.
Update the '_isOpen' field before ungrabbing.
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1284
js/ui/appDisplay.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index b7d29e149a..83f77981d1 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -2301,8 +2301,8 @@ var AppFolderDialog = GObject.registerClass({
this._zoomAndFadeOut();
this._showFolderLabel();
- this._grabHelper.ungrab({ actor: this });
this._isOpen = false;
+ this._grabHelper.ungrab({ actor: this });
this.emit('open-state-changed', false);
}
});
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]