[gnome-shell/gbsneto/custom-icon-positions] appDisplay: Update folder dialog field before ungrabbing



commit 4ec3508071023cb2182ea5cd235155ca32beaad5
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Wed Jun 24 15:32:27 2020 -0300

    appDisplay: Update folder dialog field before ungrabbing
    
    Noticed while working on customizable folders. Calling GrabHelper.ungrab()
    ends up calling FolderDialog.popdown(), but at this poind the '_isOpen'
    field isn't updated yet, so we end up calling popdown() twice.
    
    Update the '_isOpen' field before ungrabbing.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1284

 js/ui/appDisplay.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 5fefe49926..2435a1a155 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -2298,11 +2298,12 @@ var AppFolderDialog = GObject.registerClass({
         if (!this._isOpen)
             return;
 
+        this._isOpen = false;
+
         this._zoomAndFadeOut();
         this._showFolderLabel();
 
         this._grabHelper.ungrab({ actor: this });
-        this._isOpen = false;
         this.emit('open-state-changed', false);
     }
 });


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]