[gnome-shell/wip/exalm/gestures2: 5/5] workspaceAnimation: Use a workspace strip
- From: Alexander Mikhaylenko <alexm src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/exalm/gestures2: 5/5] workspaceAnimation: Use a workspace strip
- Date: Sat, 20 Jun 2020 17:02:52 +0000 (UTC)
commit fb920506bc440ac6fb45133ffcdf90f96bcd0632
Author: Alexander Mikhaylenko <exalm7659 gmail com>
Date: Sat Jun 20 22:01:25 2020 +0500
workspaceAnimation: Use a workspace strip
js/ui/workspaceAnimation.js | 209 ++++++++++++++------------------------------
1 file changed, 64 insertions(+), 145 deletions(-)
---
diff --git a/js/ui/workspaceAnimation.js b/js/ui/workspaceAnimation.js
index 21fa932508..cbd9afaa4b 100644
--- a/js/ui/workspaceAnimation.js
+++ b/js/ui/workspaceAnimation.js
@@ -114,87 +114,59 @@ var WorkspaceAnimationController = class {
this._swipeTracker = swipeTracker;
}
- _getPositionForDirection(direction, fromWs, toWs) {
- let xDest = 0, yDest = 0;
-
- let oldWsIsFullscreen = fromWs.list_windows().some(w => w.is_fullscreen());
- let newWsIsFullscreen = toWs.list_windows().some(w => w.is_fullscreen());
-
- // We have to shift windows up or down by the height of the panel to prevent having a
- // visible gap between the windows while switching workspaces. Since fullscreen windows
- // hide the panel, they don't need to be shifted up or down.
- let shiftHeight = Main.panel.height;
-
- if (direction === Meta.MotionDirection.UP ||
- direction === Meta.MotionDirection.UP_LEFT ||
- direction === Meta.MotionDirection.UP_RIGHT)
- yDest = -global.screen_height + (oldWsIsFullscreen ? 0 : shiftHeight);
- else if (direction === Meta.MotionDirection.DOWN ||
- direction === Meta.MotionDirection.DOWN_LEFT ||
- direction === Meta.MotionDirection.DOWN_RIGHT)
- yDest = global.screen_height - (newWsIsFullscreen ? 0 : shiftHeight);
-
- if (direction === Meta.MotionDirection.LEFT ||
- direction === Meta.MotionDirection.UP_LEFT ||
- direction === Meta.MotionDirection.DOWN_LEFT)
- xDest = -global.screen_width;
- else if (direction === Meta.MotionDirection.RIGHT ||
- direction === Meta.MotionDirection.UP_RIGHT ||
- direction === Meta.MotionDirection.DOWN_RIGHT)
- xDest = global.screen_width;
-
- return [xDest, yDest];
- }
-
- _prepareWorkspaceSwitch(from, to, direction) {
+ _prepareWorkspaceSwitch() {
if (this._switchData)
return;
let wgroup = global.window_group;
let workspaceManager = global.workspace_manager;
- let curWs = workspaceManager.get_workspace_by_index(from);
+ let vertical = workspaceManager.layout_rows === -1;
+ let nWorkspaces = workspaceManager.get_n_workspaces();
let switchData = {};
this._switchData = switchData;
- switchData.curGroup = new WorkspaceGroup(this, curWs);
switchData.movingWindowBin = new Clutter.Actor();
switchData.movingWindow = null;
- switchData.surroundings = {};
+ switchData.workspaces = [];
switchData.gestureActivated = false;
switchData.inProgress = false;
switchData.container = new Clutter.Actor();
- switchData.container.add_actor(switchData.curGroup);
wgroup.add_actor(switchData.movingWindowBin);
wgroup.add_actor(switchData.container);
- for (let dir of Object.values(Meta.MotionDirection)) {
- let ws = null;
+ let x = 0;
+ let y = 0;
- if (to < 0)
- ws = curWs.get_neighbor(dir);
- else if (dir === direction)
- ws = workspaceManager.get_workspace_by_index(to);
+ for (let i = 0; i < nWorkspaces; i++) {
+ let ws = workspaceManager.get_workspace_by_index(i);
+ let fullscreen = ws.list_windows().some(w => w.is_fullscreen());
- if (ws === null || ws === curWs) {
- switchData.surroundings[dir] = null;
- continue;
+ if (i > 0 && vertical && !fullscreen) {
+ // We have to shift windows up or down by the height of the panel to prevent having a
+ // visible gap between the windows while switching workspaces. Since fullscreen windows
+ // hide the panel, they don't need to be shifted up or down.
+ y -= Main.panel.height;
}
- let [x, y] = this._getPositionForDirection(dir, curWs, ws);
let info = {
- index: ws.index(),
actor: new WorkspaceGroup(this, ws),
- xDest: x,
- yDest: y,
+ fullscreen,
+ x,
+ y,
};
- switchData.surroundings[dir] = info;
+
+ switchData.workspaces[i] = info;
switchData.container.add_actor(info.actor);
switchData.container.set_child_above_sibling(info.actor, null);
-
info.actor.set_position(x, y);
+
+ if (vertical)
+ y += global.screen_height;
+ else
+ x += global.screen_width;
}
wgroup.set_child_above_sibling(switchData.movingWindowBin, null);
@@ -234,25 +206,18 @@ var WorkspaceAnimationController = class {
}
animateSwitchWorkspace(from, to, direction, onComplete) {
- this._prepareWorkspaceSwitch(from, to, direction);
+ this._prepareWorkspaceSwitch();
this._switchData.inProgress = true;
- let workspaceManager = global.workspace_manager;
- let fromWs = workspaceManager.get_workspace_by_index(from);
- let toWs = workspaceManager.get_workspace_by_index(to);
+ let fromWs = this._switchData.workspaces[from];
+ let toWs = this._switchData.workspaces[to];
- let [xDest, yDest] = this._getPositionForDirection(direction, fromWs, toWs);
-
- /* @direction is the direction that the "camera" moves, so the
- * screen contents have to move one screen's worth in the
- * opposite direction.
- */
- xDest = -xDest;
- yDest = -yDest;
+ this._switchData.container.x = -fromWs.x;
+ this._switchData.container.y = -fromWs.y;
this._switchData.container.ease({
- x: xDest,
- y: yDest,
+ x: -toWs.x,
+ y: -toWs.y,
duration: WINDOW_ANIMATION_TIME,
mode: Clutter.AnimationMode.EASE_OUT_CUBIC,
onComplete: () => {
@@ -262,53 +227,6 @@ var WorkspaceAnimationController = class {
});
}
- _directionForProgress(progress) {
- if (global.workspace_manager.layout_rows === -1) {
- return progress > 0
- ? Meta.MotionDirection.DOWN
- : Meta.MotionDirection.UP;
- } else if (Clutter.get_default_text_direction() === Clutter.TextDirection.RTL) {
- return progress > 0
- ? Meta.MotionDirection.LEFT
- : Meta.MotionDirection.RIGHT;
- } else {
- return progress > 0
- ? Meta.MotionDirection.RIGHT
- : Meta.MotionDirection.LEFT;
- }
- }
-
- _getProgressRange() {
- if (!this._switchData)
- return [0, 0];
-
- let lower = 0;
- let upper = 0;
-
- let horiz = global.workspace_manager.layout_rows !== -1;
- let baseDistance;
- if (horiz)
- baseDistance = global.screen_width;
- else
- baseDistance = global.screen_height;
-
- let direction = this._directionForProgress(-1);
- let info = this._switchData.surroundings[direction];
- if (info !== null) {
- let distance = horiz ? info.xDest : info.yDest;
- lower = -Math.abs(distance) / baseDistance;
- }
-
- direction = this._directionForProgress(1);
- info = this._switchData.surroundings[direction];
- if (info !== null) {
- let distance = horiz ? info.xDest : info.yDest;
- upper = Math.abs(distance) / baseDistance;
- }
-
- return [lower, upper];
- }
-
_switchWorkspaceBegin(tracker, monitor) {
if (Meta.prefs_get_workspaces_only_on_primary() &&
monitor !== Main.layoutManager.primaryIndex)
@@ -320,13 +238,7 @@ var WorkspaceAnimationController = class {
? Clutter.Orientation.HORIZONTAL
: Clutter.Orientation.VERTICAL;
- let activeWorkspace = workspaceManager.get_active_workspace();
-
- let baseDistance;
- if (horiz)
- baseDistance = global.screen_width;
- else
- baseDistance = global.screen_height;
+ let baseDistance = horiz ? global.screen_width : global.screen_width;
let progress;
if (this._switchData && this._switchData.gestureActivated) {
@@ -338,20 +250,28 @@ var WorkspaceAnimationController = class {
else
progress = -this._switchData.container.x / baseDistance;
} else {
- this._prepareWorkspaceSwitch(activeWorkspace.index(), -1);
- progress = 0;
- }
-
- let points = [];
- let [lower, upper] = this._getProgressRange();
+ this._prepareWorkspaceSwitch();
- if (lower !== 0)
- points.push(lower);
+ let activeIndex = workspaceManager.get_active_index();
+ let ws = this._switchData.workspaces[activeIndex];
- points.push(0);
+ if (!horiz)
+ progress = -ws.y / baseDistance;
+ else if (Clutter.get_default_text_direction() === Clutter.TextDirection.RTL)
+ progress = ws.x / baseDistance;
+ else
+ progress = -ws.x / baseDistance;
+ }
- if (upper !== 0)
- points.push(upper);
+ let points = [];
+ for (let ws of this._switchData.workspaces) {
+ if (!horiz)
+ points.push(-ws.y / baseDistance);
+ else if (Clutter.get_default_text_direction() === Clutter.TextDirection.RTL)
+ points.push(ws.x / baseDistance);
+ else
+ points.push(-ws.x / baseDistance);
+ }
tracker.confirmSwipe(baseDistance, points, progress, 0);
}
@@ -360,18 +280,15 @@ var WorkspaceAnimationController = class {
if (!this._switchData)
return;
- let direction = this._directionForProgress(progress);
- let info = this._switchData.surroundings[direction];
let xPos = 0;
let yPos = 0;
- if (info) {
- if (global.workspace_manager.layout_rows === -1)
- yPos = -Math.round(progress * global.screen_height);
- else if (Clutter.get_default_text_direction() === Clutter.TextDirection.RTL)
- xPos = Math.round(progress * global.screen_width);
- else
- xPos = -Math.round(progress * global.screen_width);
- }
+
+ if (global.workspace_manager.layout_rows === -1)
+ yPos = -Math.round(progress * global.screen_height);
+ else if (Clutter.get_default_text_direction() === Clutter.TextDirection.RTL)
+ xPos = Math.round(progress * global.screen_width);
+ else
+ xPos = -Math.round(progress * global.screen_width);
this._switchData.container.set_position(xPos, yPos);
}
@@ -386,10 +303,12 @@ var WorkspaceAnimationController = class {
let xDest = 0;
let yDest = 0;
if (endProgress !== 0) {
- let direction = this._directionForProgress(endProgress);
- newWs = activeWorkspace.get_neighbor(direction);
- xDest = -this._switchData.surroundings[direction].xDest;
- yDest = -this._switchData.surroundings[direction].yDest;
+ if (global.workspace_manager.layout_rows === -1)
+ yDest = -Math.round(endProgress * global.screen_height);
+ else if (Clutter.get_default_text_direction() === Clutter.TextDirection.RTL)
+ xDest = Math.round(endProgress * global.screen_width);
+ else
+ xDest = -Math.round(endProgress * global.screen_width);
}
let switchData = this._switchData;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]