[seahorse/gnome-3-36] pgp: Don't show 'Indicate trust' before importing



commit 91df1e34950d187095870e35c734b56de5960400
Author: Niels De Graef <nielsdegraef gmail com>
Date:   Sat Jun 20 15:41:02 2020 +0200

    pgp: Don't show 'Indicate trust' before importing
    
    We only hid the combobox, which confusingly led to a label with a title
    being show, but it didn't actually do anything.
    
    Fixes https://gitlab.gnome.org/GNOME/seahorse/-/issues/286

 pgp/seahorse-pgp-key-properties.c         | 4 +++-
 pgp/seahorse-pgp-public-key-properties.ui | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/pgp/seahorse-pgp-key-properties.c b/pgp/seahorse-pgp-key-properties.c
index 9f48905d..d1e4820d 100644
--- a/pgp/seahorse-pgp-key-properties.c
+++ b/pgp/seahorse-pgp-key-properties.c
@@ -86,6 +86,7 @@ struct _SeahorsePgpKeyProperties {
     GtkLabel *details_created_label;
     GtkLabel *details_strength_label;
     GtkLabel *details_expires_label;
+    GtkBox *indicate_trust_box;
     GtkComboBox *details_trust_combobox;
     GtkTreeView *details_subkey_tree;
 
@@ -1240,7 +1241,7 @@ do_details (SeahorsePgpKeyProperties *self)
         expires_str = seahorse_util_get_display_date_string (expires);
     gtk_label_set_text (self->details_expires_label, expires_str);
 
-    gtk_widget_set_visible (GTK_WIDGET (self->details_trust_combobox),
+    gtk_widget_set_visible (GTK_WIDGET (self->indicate_trust_box),
                             SEAHORSE_GPGME_IS_KEY (self->key));
     gtk_widget_set_sensitive (GTK_WIDGET (self->details_trust_combobox),
                               !(seahorse_object_get_flags (SEAHORSE_OBJECT (self->key)) & 
SEAHORSE_FLAG_DISABLED));
@@ -1701,6 +1702,7 @@ get_common_widgets (SeahorsePgpKeyProperties *self, GtkBuilder *builder)
     self->details_created_label = GTK_LABEL (gtk_builder_get_object (builder, "details-created-label"));
     self->details_strength_label = GTK_LABEL (gtk_builder_get_object (builder, "details-strength-label"));
     self->details_expires_label = GTK_LABEL (gtk_builder_get_object (builder, "details-expires-label"));
+    self->indicate_trust_box = GTK_BOX (gtk_builder_get_object (builder, "indicate_trust_box"));
     self->details_trust_combobox = GTK_COMBO_BOX (gtk_builder_get_object (builder, 
"details-trust-combobox"));
     self->details_subkey_tree = GTK_TREE_VIEW (gtk_builder_get_object (builder, "details-subkey-tree"));
 
diff --git a/pgp/seahorse-pgp-public-key-properties.ui b/pgp/seahorse-pgp-public-key-properties.ui
index 10f412d4..7b21ef48 100644
--- a/pgp/seahorse-pgp-public-key-properties.ui
+++ b/pgp/seahorse-pgp-public-key-properties.ui
@@ -815,7 +815,7 @@ B4C3 4349 0932 7854 3452</property>
                           </object>
                         </child>
                         <child>
-                          <object class="GtkBox">
+                          <object class="GtkBox" id="indicate_trust_box">
                             <property name="visible">True</property>
                             <property name="orientation">vertical</property>
                             <property name="can_focus">False</property>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]