[libhandy/wip/exalm/leaflet-transltions: 8/14] stackable-box: Stop setting visibility in set_position()



commit 897423838d699c5a2f70fec33d15d3a70a273921
Author: Alexander Mikhaylenko <alexm gnome org>
Date:   Fri May 29 00:57:06 2020 +0500

    stackable-box: Stop setting visibility in set_position()
    
    Looks like this isn't needed anymore, and will cause extra signal
    emissions later.
    
    Signed-off-by: Alexander Mikhaylenko <alexm gnome org>

 src/hdy-stackable-box.c | 15 ---------------
 1 file changed, 15 deletions(-)
---
diff --git a/src/hdy-stackable-box.c b/src/hdy-stackable-box.c
index 31daa37e..324e804d 100644
--- a/src/hdy-stackable-box.c
+++ b/src/hdy-stackable-box.c
@@ -617,23 +617,8 @@ static void
 hdy_stackable_box_set_position (HdyStackableBox *self,
                                 gdouble          pos)
 {
-  gboolean new_visible;
-  GtkWidget *child;
-
   self->mode_transition.current_pos = pos;
 
-  /* We check mode_transition.target_pos here too, because we want to ensure we set
-   * child_visible immediately when starting a reveal operation
-   * otherwise the child widgets will not be properly realized
-   * after the reveal returns.
-   */
-  new_visible = self->mode_transition.current_pos != 0.0 || self->mode_transition.target_pos != 0.0;
-
-  child = hdy_stackable_box_get_visible_child (self);
-  if (child != NULL &&
-      new_visible != gtk_widget_get_child_visible (child))
-    gtk_widget_set_child_visible (child, new_visible);
-
   gtk_widget_queue_allocate (GTK_WIDGET (self->container));
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]