[gimp/gimp-2-10] Issue #5226 - hover over toolgroup not working



commit 00145da370877341ec79e67977123d3a72cd2234
Author: Ell <ell_se yahoo com>
Date:   Tue Jun 16 12:59:24 2020 +0300

    Issue #5226 - hover over toolgroup not working
    
    In gimp_tool_button_enter_notify(), only mask-in the mouse-button
    state for determining whether to show the tool-group menu.  This
    avoids other bits of state -- in particular, certain keyboard
    locks, including keyboard-layout state -- from preventing the menu
    from showing.

 app/widgets/gimptoolbutton.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
---
diff --git a/app/widgets/gimptoolbutton.c b/app/widgets/gimptoolbutton.c
index ce340f4d0e..e18dd09d7e 100644
--- a/app/widgets/gimptoolbutton.c
+++ b/app/widgets/gimptoolbutton.c
@@ -671,11 +671,19 @@ gimp_tool_button_enter_notify (GtkWidget        *widget,
                                GdkEventCrossing *event,
                                GimpToolButton   *tool_button)
 {
+  guint button_state;
+
+  button_state = event->state & (GDK_BUTTON1_MASK |
+                                 GDK_BUTTON2_MASK |
+                                 GDK_BUTTON3_MASK |
+                                 GDK_BUTTON4_MASK |
+                                 GDK_BUTTON5_MASK);
+
   if (tool_button->priv->menu                            &&
       tool_button->priv->show_menu_on_hover              &&
       ! gtk_widget_get_visible (tool_button->priv->menu) &&
       event->mode == GDK_CROSSING_NORMAL                 &&
-      event->state == 0)
+      button_state == 0)
     {
       if (tool_button->priv->menu_idle_id)
         {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]