[gnome-shell/gbsneto/pagination: 60/70] appDisplay: Redisplay folders before AppDisplay
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/gbsneto/pagination: 60/70] appDisplay: Redisplay folders before AppDisplay
- Date: Tue, 16 Jun 2020 00:36:58 +0000 (UTC)
commit 000eb8d7cfcf5b81f3b3a144d0cc8434f0559fea
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date: Tue May 19 17:32:22 2020 -0300
appDisplay: Redisplay folders before AppDisplay
When filtering out the app icons, AppDisplay calls FolderIcon.getAppIds(),
which then calls FolderView.getAllItems(). This last function reads the
already added app icons inside the given folder, and return their app ids.
So far, so good.
When the GSettings backing a folder changes, FolderIcon emits 'apps-changed'
to notify AppDisplay that the folder changed.
Cool.
When AppDisplay receives this signal, it first recreates its own icons, then
updates the folders, and finally hides the icons that are inside folders.
This series of events is unfortunate. Future patches will need the folder
to be updated *before* AppDisplay updates its own icons.
Update folder icons before chaining up to BaseAppView._redisplay().
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1271
js/ui/appDisplay.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 02b41f432a..c1db69d1c3 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -430,11 +430,11 @@ class AppDisplay extends BaseAppView {
}
_redisplay() {
- super._redisplay();
-
this._folderIcons.forEach(icon => {
icon.view._redisplay();
});
+
+ super._redisplay();
this._refilterApps();
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]