[cantarell-fonts/housekeeping] Comment why we don't optimize
- From: Nikolaus Waxweiler <nwaxweiler src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [cantarell-fonts/housekeeping] Comment why we don't optimize
- Date: Sat, 13 Jun 2020 21:10:09 +0000 (UTC)
commit be181d43c827f582c6c60b008ecdb86b59ceb784
Author: Nikolaus Waxweiler <madigens gmail com>
Date: Sat Jun 13 22:09:54 2020 +0100
Comment why we don't optimize
scripts/make-static-fonts.py | 3 ++-
scripts/make-variable-font.py | 7 ++-----
2 files changed, 4 insertions(+), 6 deletions(-)
---
diff --git a/scripts/make-static-fonts.py b/scripts/make-static-fonts.py
index 634daf45..6f500fe7 100644
--- a/scripts/make-static-fonts.py
+++ b/scripts/make-static-fonts.py
@@ -26,7 +26,8 @@ def generate_and_write_autohinted_instance(
# 3.5. Optionally write instance UFO to disk, for debugging.
# instance.save(output_dir / f"{file_stem}.ufo", overwrite=True)
- # 4. Compile and write instance OTF to disk.
+ # 4. Compile and write instance OTF to disk. Do not optimize, because we have to
+ # do it again after autohinting.
instance_font = ufo2ft.compileOTF(
instance,
removeOverlaps=True,
diff --git a/scripts/make-variable-font.py b/scripts/make-variable-font.py
index 944d99d7..65404fb1 100644
--- a/scripts/make-variable-font.py
+++ b/scripts/make-variable-font.py
@@ -30,10 +30,6 @@ parser.add_argument(
parser.add_argument(
"psautohint_path", type=Path, help="The path to the psautohint executable."
)
-parser.add_argument("tx_path", type=Path, help="The path to the AFDKO's tx executable.")
-parser.add_argument(
- "sfntedit_path", type=Path, help="The path to the AFDKO's sfntedit executable."
-)
parser.add_argument("output_path", type=Path, help="The variable TTF output path.")
args = parser.parse_args()
@@ -51,7 +47,8 @@ designspace.instances = [
s for s in designspace.instances if s.lib.get("com.schriftgestaltung.export", True)
]
-# 2. Compile variable OTF from the masters.
+# 2. Compile variable OTF from the masters. Do not optimize, because we have to do
+# it again after autohinting.
varfont = ufo2ft.compileVariableCFF2(
designspace,
inplace=True,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]