[orca] Don't automatically set locusOfFocus to newly-added web dialog
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] Don't automatically set locusOfFocus to newly-added web dialog
- Date: Fri, 12 Jun 2020 16:41:34 +0000 (UTC)
commit 15c3d04df0d63ce8e183788bd4c8021f902c07c9
Author: Joanmarie Diggs <jdiggs igalia com>
Date: Fri Jun 12 12:36:24 2020 -0400
Don't automatically set locusOfFocus to newly-added web dialog
This old workaround for a Firefox bug causes us to stop preventing events
in certain web apps (e.g. Google Docs) when a dialog appears but lacks
focus. If there is a Firefox dialog which fails to give us the expected
events, we should get it fixed there or work around the problem in the
Gecko script.
src/orca/scripts/web/script.py | 6 ------
1 file changed, 6 deletions(-)
---
diff --git a/src/orca/scripts/web/script.py b/src/orca/scripts/web/script.py
index b7dc65a85..96bc2f13d 100644
--- a/src/orca/scripts/web/script.py
+++ b/src/orca/scripts/web/script.py
@@ -1747,12 +1747,6 @@ class Script(default.Script):
self.utilities.setCaretContext(focused, 0)
return True
- if childRole == pyatspi.ROLE_DIALOG:
- msg = "WEB: Setting locusOfFocus to event.any_data"
- debug.println(debug.LEVEL_INFO, msg, True)
- orca.setLocusOfFocus(event, event.any_data)
- return True
-
if self.lastMouseRoutingTime and 0 < time.time() - self.lastMouseRoutingTime < 1:
utterances = []
utterances.append(messages.NEW_ITEM_ADDED)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]