[baobab] Do not sort model until the scan is completed
- From: Stefano Facchini <sfacchini src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [baobab] Do not sort model until the scan is completed
- Date: Fri, 12 Jun 2020 13:14:13 +0000 (UTC)
commit 6bf17450eda5464808830f667306a18c345f3a93
Author: Stefano Facchini <stefano facchini gmail com>
Date: Mon Jun 8 11:01:24 2020 +0200
Do not sort model until the scan is completed
Ordered insertion becomes too slow for directories with many entries.
src/baobab-scanner.vala | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/src/baobab-scanner.vala b/src/baobab-scanner.vala
index 9db09ea..2d73009 100644
--- a/src/baobab-scanner.vala
+++ b/src/baobab-scanner.vala
@@ -297,7 +297,7 @@ namespace Baobab {
parent_iter = null;
}
- append (out results.iter, parent_iter);
+ prepend (out results.iter, parent_iter);
set (results.iter,
Columns.STATE, State.SCANNING,
Columns.DISPLAY_NAME, results.display_name,
@@ -385,6 +385,7 @@ namespace Baobab {
hardlinks = new GenericSet<HardLink> (HardLink.hash, HardLink.equal);
base.clear ();
+ set_sort_column_id (Gtk.SortColumn.UNSORTED, Gtk.SortType.DESCENDING);
cancellable.reset ();
scan_error = null;
@@ -422,6 +423,8 @@ namespace Baobab {
}
public void finish () throws Error {
+ set_sort_column_id (Columns.SIZE, Gtk.SortType.DESCENDING);
+
if (scan_error != null) {
throw scan_error;
}
@@ -443,7 +446,6 @@ namespace Baobab {
typeof (State), // STATE
typeof (Error) // ERROR (if STATE is ERROR)
});
- set_sort_column_id (Columns.SIZE, Gtk.SortType.DESCENDING);
excluded_locations = Application.get_default ().get_excluded_locations ();
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]