[gnome-contacts/fmuellner/fix-app-tracking] ui: Don't set SetupWindow's visible property



commit 1b4a6995293f69b50ae711bf52be30fa8e2af8e4
Author: Florian Müllner <fmuellner gnome org>
Date:   Fri Jun 12 03:15:12 2020 +0200

    ui: Don't set SetupWindow's visible property
    
    When initializing a widget, the template is processed before the
    construct properties. That's usually fine, but showing a toplevel
    window has the side effect of realizing it; doing that before the
    window is associated with an application means that properties like
    the GTK application ID won't be exported, and gnome-shell fails to
    match the window to the correct .desktop file as a result.
    
    Just remove the property from the template, the code already handles
    showingi the window.
    
    See https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2893

 data/ui/contacts-setup-window.ui | 1 -
 1 file changed, 1 deletion(-)
---
diff --git a/data/ui/contacts-setup-window.ui b/data/ui/contacts-setup-window.ui
index 1391f32..4d25064 100644
--- a/data/ui/contacts-setup-window.ui
+++ b/data/ui/contacts-setup-window.ui
@@ -2,7 +2,6 @@
 <interface>
   <!-- interface-requires gtk+ 3.22 -->
   <template class="ContactsSetupWindow" parent="GtkApplicationWindow">
-    <property name="visible">True</property>
     <property name="default_width">800</property>
     <property name="default_height">600</property>
     <child type="titlebar">


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]