[gnome-shell/eos3.8: 172/255] messageTray: Don't expire a notification if its focus grabber is focused
- From: Matthew Leeds <mwleeds src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/eos3.8: 172/255] messageTray: Don't expire a notification if its focus grabber is focused
- Date: Wed, 10 Jun 2020 19:12:26 +0000 (UTC)
commit c21cbdea44763179d4673e6538768154d9499e6c
Author: Travis Reitter <travis reitter endlessm com>
Date: Mon Nov 26 16:34:58 2018 -0800
messageTray: Don't expire a notification if its focus grabber is focused
Without this change, it seems that even focused notifications will be
automatically destroyed after a brief timeout unless the mouse cursor is
positioned within and held within them shortly after the cursor's first
movement after the notification appears.
It's possible this code change simply implements what the preceding line
intended. In that case, we should instead set this._banner.focused
accordingly in MessageTray._ensureBannerFocused() and unset it
accordingly elsewhere.
https://phabricator.endlessm.com/T24125
js/ui/messageTray.js | 1 +
1 file changed, 1 insertion(+)
---
diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index fffdc786dc..13d04151a8 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -1317,6 +1317,7 @@ var MessageTray = GObject.registerClass({
this._notificationTimeoutId == 0 &&
this._notification.urgency != Urgency.CRITICAL &&
!this._banner.focused &&
+ !this._notificationFocusGrabber._focused &&
!this._pointerInNotification) || this._notificationExpired;
let mustClose = this._notificationRemoved || !hasNotifications || expired;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]