[gnome-shell/eos3.8: 111/255] appDisplay: Remove contextual menu's item to add/remove favourites apps

[Matthew Leeds <mwleeds src gnome org>]

commit 1cc1764cc007f67076f310666fdacca92f0cef3a
Author: Mario Sanchez Prada <mario endlessm com>
Date:   Fri Jun 30 01:45:34 2017 +0000

    appDisplay: Remove contextual menu's item to add/remove favourites apps
    
    This functionality can be also achieved via the taskbar, by right-clicking
    on an icon and clicking on "Pin/Unpin to/from taskbar", so let's remove it
    from here to avoid confusion.
    
    https://phabricator.endlessm.com/T18013

 js/ui/appDisplay.js | 22 ----------------------
 1 file changed, 22 deletions(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index f89449d584..ecd4c89766 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -2386,28 +2386,6 @@ var AppIconMenu = class AppIconMenu extends PopupMenu.PopupMenu {
                 });
             }
 
-            let canFavorite = global.settings.is_writable('favorite-apps');
-
-            if (canFavorite) {
-                this._appendSeparator();
-
-                let isFavorite = AppFavorites.getAppFavorites().isFavorite(this._source.app.get_id());
-
-                if (isFavorite) {
-                    let item = this._appendMenuItem(_("Remove from Favorites"));
-                    item.connect('activate', () => {
-                        let favs = AppFavorites.getAppFavorites();
-                        favs.removeFavorite(this._source.app.get_id());
-                    });
-                } else {
-                    let item = this._appendMenuItem(_("Add to Favorites"));
-                    item.connect('activate', () => {
-                        let favs = AppFavorites.getAppFavorites();
-                        favs.addFavorite(this._source.app.get_id());
-                    });
-                }
-            }
-
             if (Shell.AppSystem.get_default().lookup_app('org.gnome.Software.desktop')) {
                 this._appendSeparator();
                 let item = this._appendMenuItem(_("Show Details"));