[pango/wip/baedert/for-master: 49/53] pango-context: avoid assignment to uninitialized value



commit 9983edf5294d2ae29dde8e49c7d4b94bff970ea1
Author: Timm Bäder <mail baedert org>
Date:   Wed Jun 10 05:50:51 2020 +0200

    pango-context: avoid assignment to uninitialized value
    
    We're assigning EMBEDDING_CHANGED to state->changed in
    update_embedding_end(). At that point state->changed is uninitialized,
    but that doesn't matter since we later override the value anyway.
    
    Just pull the initialization to earlier in that function, which assigns
    EMBEDDING_CHANGED anyway, so doesn't change anything.

 pango/pango-context.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/pango/pango-context.c b/pango/pango-context.c
index a64eb79f..7772878f 100644
--- a/pango/pango-context.c
+++ b/pango/pango-context.c
@@ -1006,6 +1006,8 @@ itemize_state_init (ItemizeState      *state,
   state->item = NULL;
 
   state->run_start = text + start_index;
+  state->changed = EMBEDDING_CHANGED | SCRIPT_CHANGED | LANG_CHANGED |
+                   FONT_CHANGED | WIDTH_CHANGED | EMOJI_CHANGED;
 
   /* First, apply the bidirectional algorithm to break
    * the text into directional runs.
@@ -1079,7 +1081,6 @@ itemize_state_init (ItemizeState      *state,
   state->cache = NULL;
   state->base_font = NULL;
 
-  state->changed = EMBEDDING_CHANGED | SCRIPT_CHANGED | LANG_CHANGED | FONT_CHANGED | WIDTH_CHANGED | 
EMOJI_CHANGED;
 }
 
 static gboolean


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]