[gnome-shell/gbsneto/random-cleanups-pt1: 12/13] viewSelector: Make sure it's invisible when overview is hidden



commit 5569090d1cf4077c24581a8b2076b699829eefd0
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Tue Jun 2 14:21:02 2020 -0300

    viewSelector: Make sure it's invisible when overview is hidden
    
    Instead of overriding the hide() method, use the vfunc to
    reset, and hide the workspaces display too.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1295

 js/ui/viewSelector.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
---
diff --git a/js/ui/viewSelector.js b/js/ui/viewSelector.js
index 3ec97b1cf3..aefe806a84 100644
--- a/js/ui/viewSelector.js
+++ b/js/ui/viewSelector.js
@@ -132,6 +132,7 @@ var ViewSelector = GObject.registerClass({
         super._init({
             name: 'viewSelector',
             x_expand: true,
+            visible: false,
         });
 
         this._showAppsButton = showAppsButton;
@@ -272,6 +273,7 @@ var ViewSelector = GObject.registerClass({
     }
 
     animateToOverview() {
+        this.show();
         this.reset();
         this._workspacesDisplay.animateToOverview(this._showAppsButton.checked);
         this._activePage = null;
@@ -301,9 +303,11 @@ var ViewSelector = GObject.registerClass({
         this._workspacesDisplay.setWorkspacesFullGeometry(geom);
     }
 
-    hide() {
+    vfunc_hide() {
         this.reset();
         this._workspacesDisplay.hide();
+
+        super.vfunc_hide();
     }
 
     _addPage(actor, name, a11yIcon, params) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]