[gnome-shell/gbsneto/random-cleanups-pt1: 2/5] workspacesView: Destroy views on unmap

[Georges Basile Stavracas Neto <gbsneto src gnome org>]

commit 95783defcce48366aaa680bc35a3ca86bd471bdc
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Tue Jun 2 14:15:45 2020 -0300

    workspacesView: Destroy views on unmap
    
    Instead of overriding the hide() method, destroy workspaces
    on unmap.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1295

 js/ui/viewSelector.js   | 1 -
 js/ui/workspacesView.js | 4 +++-
 2 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/viewSelector.js b/js/ui/viewSelector.js
index 930e5b1e6d..52fa664896 100644
--- a/js/ui/viewSelector.js
+++ b/js/ui/viewSelector.js
@@ -303,7 +303,6 @@ var ViewSelector = GObject.registerClass({
 
     hide() {
         this.reset();
-        this._workspacesDisplay.hide();
     }
 
     _addPage(actor, name, a11yIcon, params) {
diff --git a/js/ui/workspacesView.js b/js/ui/workspacesView.js
index b196427cc9..86b34c2127 100644
--- a/js/ui/workspacesView.js
+++ b/js/ui/workspacesView.js
@@ -640,7 +640,7 @@ class WorkspacesDisplay extends St.Widget {
         }
     }
 
-    hide() {
+    vfunc_unmap() {
         if (this._restackedNotifyId > 0) {
             Main.overview.disconnect(this._restackedNotifyId);
             this._restackedNotifyId = 0;
@@ -656,6 +656,8 @@ class WorkspacesDisplay extends St.Widget {
         for (let i = 0; i < this._workspacesViews.length; i++)
             this._workspacesViews[i].destroy();
         this._workspacesViews = [];
+
+        super.vfunc_unmap();
     }
 
     _workspacesOnlyOnPrimaryChanged() {