[gnome-shell/gbsneto/random-cleanups-pt1: 2/4] workspacesView: Rename show/hide to reveal/dismiss



commit c55a2ee6f6852ae7a77d76ed1821f7953ceab656
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Mon Jun 1 12:20:44 2020 -0300

    workspacesView: Rename show/hide to reveal/dismiss
    
    WorkspacesDisplay is a ClutterActor subclass, and overriding
    the show and hide methods require chaining up, otherwise the
    actor isn't actually shown or hidden.
    
    To avoid clashing with the pre-existing methods, rename to
    reveal/dismiss.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1295

 js/ui/viewSelector.js   | 4 ++--
 js/ui/workspacesView.js | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/js/ui/viewSelector.js b/js/ui/viewSelector.js
index 5c0dd9bb75..f0cea99206 100644
--- a/js/ui/viewSelector.js
+++ b/js/ui/viewSelector.js
@@ -273,7 +273,7 @@ var ViewSelector = GObject.registerClass({
 
     show() {
         this.reset();
-        this._workspacesDisplay.show(this._showAppsButton.checked);
+        this._workspacesDisplay.reveal(this._showAppsButton.checked);
         this._activePage = null;
         if (this._showAppsButton.checked)
             this._showPage(this._appsPage);
@@ -303,7 +303,7 @@ var ViewSelector = GObject.registerClass({
 
     hide() {
         this.reset();
-        this._workspacesDisplay.hide();
+        this._workspacesDisplay.dismiss();
     }
 
     _addPage(actor, name, a11yIcon, params) {
diff --git a/js/ui/workspacesView.js b/js/ui/workspacesView.js
index 09155c5ae1..ce7f12e811 100644
--- a/js/ui/workspacesView.js
+++ b/js/ui/workspacesView.js
@@ -608,7 +608,7 @@ class WorkspacesDisplay extends St.Widget {
         return this._getPrimaryView().navigate_focus(from, direction, false);
     }
 
-    show(fadeOnPrimary) {
+    reveal(fadeOnPrimary) {
         this._updateWorkspacesViews();
         for (let i = 0; i < this._workspacesViews.length; i++) {
             let animationType;
@@ -640,7 +640,7 @@ class WorkspacesDisplay extends St.Widget {
         }
     }
 
-    hide() {
+    dismiss() {
         if (this._restackedNotifyId > 0) {
             Main.overview.disconnect(this._restackedNotifyId);
             this._restackedNotifyId = 0;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]