[libhandy/wip/exalm/leaflet-transltions: 20/26] stackable-box: Stop setting visibility in set_position()
- From: Adrien Plazas <aplazas src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libhandy/wip/exalm/leaflet-transltions: 20/26] stackable-box: Stop setting visibility in set_position()
- Date: Tue, 2 Jun 2020 11:18:28 +0000 (UTC)
commit 6e871bf00692634fbc5414ccbbffa75c612e6f85
Author: Alexander Mikhaylenko <alexm gnome org>
Date: Fri May 29 00:57:06 2020 +0500
stackable-box: Stop setting visibility in set_position()
Looks like this isn't needed anymore, and will cause extra signal
emissions later.
Signed-off-by: Alexander Mikhaylenko <alexm gnome org>
src/hdy-stackable-box.c | 15 ---------------
1 file changed, 15 deletions(-)
---
diff --git a/src/hdy-stackable-box.c b/src/hdy-stackable-box.c
index 4bc5b7eb..c3be5f8e 100644
--- a/src/hdy-stackable-box.c
+++ b/src/hdy-stackable-box.c
@@ -648,23 +648,8 @@ static void
hdy_stackable_box_set_position (HdyStackableBox *self,
gdouble pos)
{
- gboolean new_visible;
- GtkWidget *child;
-
self->mode_transition.current_pos = pos;
- /* We check mode_transition.target_pos here too, because we want to ensure we set
- * child_visible immediately when starting a reveal operation
- * otherwise the child widgets will not be properly realized
- * after the reveal returns.
- */
- new_visible = self->mode_transition.current_pos != 0.0 || self->mode_transition.target_pos != 0.0;
-
- child = hdy_stackable_box_get_visible_child (self);
- if (child != NULL &&
- new_visible != gtk_widget_get_child_visible (child))
- gtk_widget_set_child_visible (child, new_visible);
-
/* FIXME Copied from GtkRevealer IIRC, check whether it's useful. */
/* transition = effective_transition (self); */
/* if (transition == GTK_REVEALER_TRANSITION_TYPE_CROSSFADE) { */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]