[gnome-shell] panelMenu: Destroy menu before chaining up
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
 
- To: commits-list gnome org
 
- Cc: 
 
- Subject: [gnome-shell] panelMenu: Destroy menu before chaining up
 
- Date: Wed, 29 Jul 2020 19:45:16 +0000 (UTC)
 
commit 1812db7aa80e3763f56b3cc41a162b9eb1b62b3e
Author: Florian Müllner <fmuellner gnome org>
Date:   Tue Jul 28 18:52:53 2020 +0200
    panelMenu: Destroy menu before chaining up
    
    This avoid some (harmless but annoying) warnings, and is closer to
    the original code prior to commit fc342fe8c5 and 557b232c896.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3022
 js/ui/panelMenu.js | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
---
diff --git a/js/ui/panelMenu.js b/js/ui/panelMenu.js
index 44fd763ba1..81d34490bd 100644
--- a/js/ui/panelMenu.js
+++ b/js/ui/panelMenu.js
@@ -183,10 +183,9 @@ var Button = GObject.registerClass({
     }
 
     _onDestroy() {
-        super._onDestroy();
-
         if (this.menu)
             this.menu.destroy();
+        super._onDestroy();
     }
 });
 
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]