[gnome-shell/mcatanzaro/#734996] Delay login animation until after wallpaper has loaded

[Michael Catanzaro <mcatanzaro src gnome org>]

commit f386103bc14f186bceaf75976a9659bf05dfb998
Author: Michael Catanzaro <mcatanzaro gnome org>
Date:   Mon Jul 20 19:00:32 2020 -0500

    Delay login animation until after wallpaper has loaded
    
    Currently, the login animation can occur before the user's wallpaper has
    been loaded. When this happens, we wind up displaying a solid blue
    background for half a second or so before the proper background is
    displayed. This looks jarring and bad. It's great that we can start
    GNOME quickly, but starting up before the wallpaper is ready is *too*
    quickly.
    
    I've been meaning to fix this since 2014. Better late than never! We can
    just have BackgroundManager emit a loaded signal the first time it loads
    its first background, and have the startup animation code wait for that
    before proceeding.
    
    Some of this code is by Florian, who helped with promisifying. Thanks!
    
    https://bugzilla.gnome.org/show_bug.cgi?id=734996

 js/ui/background.js |  9 +++++++++
 js/ui/layout.js     | 19 +++++++++++++++----
 2 files changed, 24 insertions(+), 4 deletions(-)
---
diff --git a/js/ui/background.js b/js/ui/background.js
index 20f5e89126..2811da3fb0 100644
--- a/js/ui/background.js
+++ b/js/ui/background.js
@@ -765,10 +765,19 @@ var BackgroundManager = class BackgroundManager {
             this._updateBackgroundActor();
         });
 
+        let loadedSignalId = background.connect('loaded', () => {
+            background.disconnect(loadedSignalId);
+            loadedSignalId = null;
+            this.emit('loaded');
+        });
+
         backgroundActor.connect('destroy', () => {
             if (changeSignalId)
                 background.disconnect(changeSignalId);
 
+            if (loadedSignalId)
+                background.disconnect(loadedSignalId);
+
             if (backgroundActor.loadedSignalId)
                 background.disconnect(backgroundActor.loadedSignalId);
         });
diff --git a/js/ui/layout.js b/js/ui/layout.js
index 55cefb2823..d37c769409 100644
--- a/js/ui/layout.js
+++ b/js/ui/layout.js
@@ -457,6 +457,15 @@ var LayoutManager = GObject.registerClass({
         }
     }
 
+    _waitLoaded(bgManager) {
+        return new Promise(resolve => {
+            const id = bgManager.connect('loaded', () => {
+                bgManager.disconnect(id);
+                resolve();
+            });
+        });
+    }
+
     _updateBackgrounds() {
         for (let i = 0; i < this._bgManagers.length; i++)
             this._bgManagers[i].destroy();
@@ -464,7 +473,7 @@ var LayoutManager = GObject.registerClass({
         this._bgManagers = [];
 
         if (Main.sessionMode.isGreeter)
-            return;
+            return Promise.resolve();
 
         for (let i = 0; i < this.monitors.length; i++) {
             let bgManager = this._createBackgroundManager(i);
@@ -473,6 +482,8 @@ var LayoutManager = GObject.registerClass({
             if (i != this.primaryIndex && this._startingUp)
                 bgManager.backgroundActor.hide();
         }
+
+        return Promise.all(this._bgManagers.map(this._waitLoaded));
     }
 
     _updateKeyboardBox() {
@@ -631,7 +642,7 @@ var LayoutManager = GObject.registerClass({
     // When starting a normal user session, we want to grow it out of the middle
     // of the screen.
 
-    _prepareStartupAnimation() {
+    async _prepareStartupAnimation() {
         // During the initial transition, add a simple actor to block all events,
         // so they don't get delivered to X11 windows that have been transformed.
         this._coverPane = new Clutter.Actor({ opacity: 0,
@@ -648,8 +659,6 @@ var LayoutManager = GObject.registerClass({
         } else if (Main.sessionMode.isGreeter) {
             this.panelBox.translation_y = -this.panelBox.height;
         } else {
-            this._updateBackgrounds();
-
             // We need to force an update of the regions now before we scale
             // the UI group to get the correct allocation for the struts.
             this._updateRegions();
@@ -665,6 +674,8 @@ var LayoutManager = GObject.registerClass({
             this.uiGroup.scale_x = this.uiGroup.scale_y = 0.75;
             this.uiGroup.opacity = 0;
             global.window_group.set_clip(monitor.x, monitor.y, monitor.width, monitor.height);
+
+            await this._updateBackgrounds();
         }
 
         this.emit('startup-prepared');