[gnome-control-center/gnome-3-36] printers: Do not authenticate SMB servers when search field is edited
- From: Robert Ancell <rancell src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-control-center/gnome-3-36] printers: Do not authenticate SMB servers when search field is edited
- Date: Fri, 17 Jul 2020 03:27:14 +0000 (UTC)
commit 6eaaf22e0a312a7343e686d77159e4a62e78e649
Author: Elia Geretto <elia f geretto gmail com>
Date: Fri Mar 6 16:12:08 2020 +0100
printers: Do not authenticate SMB servers when search field is edited
When the search field in the "Add Printer" dialog is edited, no
authentication with a remote SMB server should be attempted. The server
should just be added to the list and marked with "Server requires
authentication". The user can then authenticate the server by clicking
on it.
The behavior described above is probably the intended one when the code
was written, since there is no closure registered for the
"authentication-required" signal in the function this commit modifies.
This commit should simply restore the intended behavior.
Resolves: https://gitlab.gnome.org/GNOME/gnome-control-center/issues/755
panels/printers/pp-new-printer-dialog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/panels/printers/pp-new-printer-dialog.c b/panels/printers/pp-new-printer-dialog.c
index 81a4cc1f68..04b404edce 100644
--- a/panels/printers/pp-new-printer-dialog.c
+++ b/panels/printers/pp-new-printer-dialog.c
@@ -1496,7 +1496,7 @@ search_for_remote_printers (THostSearchData *data)
data->dialog);
pp_samba_get_devices_async (self->samba_host,
- TRUE,
+ FALSE,
self->remote_host_cancellable,
get_samba_host_devices_cb,
data->dialog);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]