[gnome-shell] workspacesView: Do not skip entire overview transition



commit 9e8883c9227bc5d1fc6dbd2eb32b1204df47c9d3
Author: Florian Müllner <fmuellner gnome org>
Date:   Sat Jul 11 18:10:18 2020 +0200

    workspacesView: Do not skip entire overview transition
    
    Since commit af543daf1c3, we skip the overview transition when the
    actual geometry hasn't been set yet. However with the new layout
    manager, the only bit that still needs the separate geometry is
    the transition of the view, the workspaces can do their transition
    just fine.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2969

 js/ui/workspacesView.js | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)
---
diff --git a/js/ui/workspacesView.js b/js/ui/workspacesView.js
index a757badbbf..c74c6e9c7e 100644
--- a/js/ui/workspacesView.js
+++ b/js/ui/workspacesView.js
@@ -551,20 +551,18 @@ class WorkspacesDisplay extends St.Widget {
         this.show();
         this._updateWorkspacesViews();
 
-        if (this._actualGeometry) {
-            for (let i = 0; i < this._workspacesViews.length; i++) {
-                let animationType;
-                if (fadeOnPrimary && i == this._primaryIndex)
-                    animationType = AnimationType.FADE;
-                else
-                    animationType = AnimationType.ZOOM;
-                this._workspacesViews[i].animateToOverview(animationType);
-            }
-
-            if (!fadeOnPrimary)
-                this._syncWorkspacesActualGeometry();
+        for (let i = 0; i < this._workspacesViews.length; i++) {
+            let animationType;
+            if (fadeOnPrimary && i == this._primaryIndex)
+                animationType = AnimationType.FADE;
+            else
+                animationType = AnimationType.ZOOM;
+            this._workspacesViews[i].animateToOverview(animationType);
         }
 
+        if (this._actualGeometry && !fadeOnPrimary)
+            this._syncWorkspacesActualGeometry();
+
         this._restackedNotifyId =
             Main.overview.connect('windows-restacked',
                                   this._onRestacked.bind(this));


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]