[gtk/wip/jimmac/file-dialog-sidebar-color] Adwaita: sidebar color for file picker
- From: Jakub Steiner <jimmac src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk/wip/jimmac/file-dialog-sidebar-color] Adwaita: sidebar color for file picker
- Date: Mon, 13 Jul 2020 15:04:15 +0000 (UTC)
commit fe5c0e2fe38b1ea3172195c4a45ef9e434498fe7
Author: Jakub Steiner <jimmac gmail com>
Date: Mon Jul 13 16:01:01 2020 +0200
Adwaita: sidebar color for file picker
- avoid using the selected blue for the sidebar
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/1586
build-aux/flatpak/org.gtk.WidgetFactory4.json | 76 ++++++++++++++++-----------
gtk/theme/Adwaita/_common.scss | 13 ++++-
2 files changed, 56 insertions(+), 33 deletions(-)
---
diff --git a/build-aux/flatpak/org.gtk.WidgetFactory4.json b/build-aux/flatpak/org.gtk.WidgetFactory4.json
index f4130c1f65..3a729087cf 100644
--- a/build-aux/flatpak/org.gtk.WidgetFactory4.json
+++ b/build-aux/flatpak/org.gtk.WidgetFactory4.json
@@ -1,29 +1,38 @@
{
- "app-id": "org.gtk.WidgetFactory4",
- "runtime": "org.gnome.Platform",
- "runtime-version": "master",
- "sdk": "org.gnome.Sdk",
- "command": "gtk4-widget-factory",
- "tags": ["devel", "development", "nightly"],
- "desktop-file-name-prefix": "(Development) ",
- "finish-args": [
+ "app-id" : "org.gtk.WidgetFactory4",
+ "runtime" : "org.gnome.Platform",
+ "runtime-version" : "master",
+ "sdk" : "org.gnome.Sdk",
+ "command" : "gtk4-widget-factory",
+ "tags" : [
+ "devel",
+ "development",
+ "nightly"
+ ],
+ "desktop-file-name-prefix" : "(Development) ",
+ "finish-args" : [
"--device=dri",
"--share=ipc",
"--socket=fallback-x11",
"--socket=wayland",
- "--talk-name=org.gtk.vfs", "--talk-name=org.gtk.vfs.*"
+ "--talk-name=org.gtk.vfs",
+ "--talk-name=org.gtk.vfs.*"
],
- "cleanup": [
+ "cleanup" : [
"/include",
- "/lib/pkgconfig", "/share/pkgconfig",
+ "/lib/pkgconfig",
+ "/share/pkgconfig",
"/share/aclocal",
- "/man", "/share/man", "/share/gtk-doc",
- "*.la", ".a",
+ "/man",
+ "/share/man",
+ "/share/gtk-doc",
+ "*.la",
+ ".a",
"/lib/girepository-1.0",
"/share/gir-1.0",
"/share/doc"
],
- "modules": [
+ "modules" : [
{
"name" : "wayland",
"buildsystem" : "autotools",
@@ -39,18 +48,18 @@
]
},
{
- "name": "graphene",
- "buildsystem": "meson",
- "builddir": true,
- "config-opts": [
+ "name" : "graphene",
+ "buildsystem" : "meson",
+ "builddir" : true,
+ "config-opts" : [
"--libdir=/app/lib",
"-Dtests=false",
"-Dbenchmarks=false"
],
- "sources": [
+ "sources" : [
{
- "type": "git",
- "url": "https://github.com/ebassi/graphene.git"
+ "type" : "git",
+ "url" : "https://github.com/ebassi/graphene.git"
}
]
},
@@ -58,7 +67,7 @@
"name" : "libsass",
"buildsystem" : "meson",
"builddir" : true,
- "config-opts": [
+ "config-opts" : [
"--libdir=/app/lib"
],
"sources" : [
@@ -73,7 +82,7 @@
"name" : "sassc",
"buildsystem" : "meson",
"builddir" : true,
- "config-opts": [
+ "config-opts" : [
"--libdir=/app/lib"
],
"sources" : [
@@ -85,18 +94,23 @@
]
},
{
- "name": "gtk",
- "buildsystem": "meson",
- "builddir": true,
- "config-opts": [
+ "name" : "gtk",
+ "buildsystem" : "meson",
+ "builddir" : true,
+ "config-opts" : [
"--libdir=/app/lib"
],
- "sources": [
+ "sources" : [
{
- "type": "git",
- "url": "https://gitlab.gnome.org/GNOME/gtk.git"
+ "type" : "git",
+ "url" : "https://gitlab.gnome.org/GNOME/gtk.git"
}
]
}
- ]
+ ],
+ "build-options" : {
+ "env" : {
+ "DBUS_SESSION_BUS_ADDRESS" : "''"
+ }
+ }
}
diff --git a/gtk/theme/Adwaita/_common.scss b/gtk/theme/Adwaita/_common.scss
index 7e829c1b4b..49199896bf 100644
--- a/gtk/theme/Adwaita/_common.scss
+++ b/gtk/theme/Adwaita/_common.scss
@@ -3343,7 +3343,17 @@ placessidebar {
// will make the animation of the new bookmark row jump
> revealer { padding: 0 14px; }
- &:selected { color: $selected_fg_color; }
+ &:selected {
+ background-color: $menu_selected_color;
+ color: $fg_color;
+
+ &:focus, &:hover {
+ color: $selected_fg_color;
+ background-color: $selected_bg_color;
+ }
+ }
+
+
&:disabled { color: $insensitive_fg_color; }
@@ -3361,7 +3371,6 @@ placessidebar {
@extend %button_basic_flat;
@extend %button_selected_flat;
-
min-height: 26px;
min-width: 26px;
margin-top: 3px;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]