[geary/mjog/mail-merge-plugin] src/client: Misc minor build warning and doc comment updates

[Michael Gratton <mjog src gnome org>]

commit 46f2787f2d10d658e5092e62fa33a47759c06479
Author: Michael Gratton <mike vee net>
Date:   Tue Jul 7 10:31:26 2020 +1000

    src/client: Misc minor build warning and doc comment updates

 src/client/application/application-plugin-manager.vala   | 8 --------
 src/client/components/components-preferences-window.vala | 1 -
 src/client/plugin/messaging-menu/messaging-menu.vala     | 6 +++++-
 src/client/plugin/special-folders/special-folders.vala   | 4 ++++
 4 files changed, 9 insertions(+), 10 deletions(-)
---
diff --git a/src/client/application/application-plugin-manager.vala 
b/src/client/application/application-plugin-manager.vala
index 5c3cf87ad..4be609810 100644
--- a/src/client/application/application-plugin-manager.vala
+++ b/src/client/application/application-plugin-manager.vala
@@ -575,14 +575,6 @@ public class Application.PluginManager : GLib.Object {
         return info.get_module_name() in AUTOLOAD_MODULES;
     }
 
-    internal Gee.Iterator<Plugin.Application> get_plugin_applications() {
-        return Geary.traverse(
-            this.plugin_set.values
-        ).map<Plugin.Application>(
-            (ctx) => ctx.instance.plugin_application
-        ).iterator();
-    }
-
     internal Gee.Collection<NotificationPluginContext> get_notification_contexts() {
         return this.notification_contexts.values.read_only_view;
     }
diff --git a/src/client/components/components-preferences-window.vala 
b/src/client/components/components-preferences-window.vala
index 598745265..f39fd65bd 100644
--- a/src/client/components/components-preferences-window.vala
+++ b/src/client/components/components-preferences-window.vala
@@ -32,7 +32,6 @@ public class Components.PreferencesWindow : Hdy.PreferencesWindow {
             this.sw.notify["active"].connect_after(() => update_plugin());
             this.sw.valign = CENTER;
 
-            var row = new Hdy.ActionRow();
             this.title = plugin.get_name();
             this.subtitle = plugin.get_description();
             this.activatable_widget = this.sw;
diff --git a/src/client/plugin/messaging-menu/messaging-menu.vala 
b/src/client/plugin/messaging-menu/messaging-menu.vala
index 46ed8eecf..0527d22af 100644
--- a/src/client/plugin/messaging-menu/messaging-menu.vala
+++ b/src/client/plugin/messaging-menu/messaging-menu.vala
@@ -15,7 +15,11 @@ public void peas_register_types(TypeModule module) {
     );
 }
 
-/** Updates the Unity messaging menu when new mail arrives. */
+/**
+ * Updates the Unity messaging menu when new mail arrives.
+ *
+ * @link https://wiki.ubuntu.com/MessagingMenu#Recommended_behavior_for_e-mail_clients
+ */
 public class Plugin.MessagingMenu :
     PluginBase, NotificationExtension, FolderExtension {
 
diff --git a/src/client/plugin/special-folders/special-folders.vala 
b/src/client/plugin/special-folders/special-folders.vala
index 109ab1162..97d2b66ab 100644
--- a/src/client/plugin/special-folders/special-folders.vala
+++ b/src/client/plugin/special-folders/special-folders.vala
@@ -100,6 +100,10 @@ public class Plugin.SpecialFolders :
                 target, get_folder_info_bar(target), PRIORITY
             );
             break;
+
+        default:
+            // noop
+            break;
         }
     }