[gnome-shell] keyboard: Fix setting height in portrait orientation



commit 1e72874192d16e9063c7a4766e53f53dfd6d130e
Author: Florian Müllner <fmuellner gnome org>
Date:   Sat Jul 4 02:22:10 2020 +0200

    keyboard: Fix setting height in portrait orientation
    
    get_preferred_height() returns both the minimum and natural height,
    not a single size. Math.min() doesn't handle that and returns NaN,
    whoops.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2349

 js/ui/keyboard.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js
index 7df7ef16da..62df5922f7 100644
--- a/js/ui/keyboard.js
+++ b/js/ui/keyboard.js
@@ -1608,7 +1608,8 @@ class Keyboard extends St.BoxLayout {
              * we allow the OSK being smaller than 1/3rd of the monitor height
              * there.
              */
-            this.height = Math.min(maxHeight, this.get_preferred_height(monitor.width));
+            const [, natHeight] = this.get_preferred_height(monitor.width);
+            this.height = Math.min(maxHeight, natHeight);
         }
     }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]