[orca] Remove workaround for implementors which do not include numlock modifier
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] Remove workaround for implementors which do not include numlock modifier
- Date: Mon, 6 Jul 2020 14:32:51 +0000 (UTC)
commit daa78c36316d8af0d92224e3aefc3b5491157ff7
Author: Joanmarie Diggs <jdiggs igalia com>
Date: Mon Jul 6 16:31:41 2020 +0200
Remove workaround for implementors which do not include numlock modifier
False positives were breaking certain commands.
src/orca/input_event.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/src/orca/input_event.py b/src/orca/input_event.py
index 7f2b32fe9..8211d6ffb 100644
--- a/src/orca/input_event.py
+++ b/src/orca/input_event.py
@@ -264,12 +264,12 @@ class KeyboardEvent(InputEvent):
self.id in KeyboardEvent.GDK_ACCENTED_LETTER_KEYS):
self.event_string = chr(self.id)
- # Some implementors don't include numlock in the modifiers.
+ # Some implementors don't include numlock in the modifiers. Unfortunately,
+ # trying to heuristically hack around this just by looking at the event
+ # is not reliable. Ditto regarding asking Gdk for the numlock state.
if self.keyval_name.startswith("KP"):
if event.modifiers & (1 << pyatspi.MODIFIER_NUMLOCK):
self._is_kp_with_numlock = True
- else:
- self._is_kp_with_numlock = self.isPrintableKey()
if self._script:
self._app = self._script.app
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]