GNOME.org
 

[gnome-builder/gnome-builder-3-36] html-preview: use json.dumps() for markup conversion

commit be79db6184a1a4013e09751c2ac0a111c07d5cf0
Author: Christian Hergert <chergert redhat com>
Date:   Wed Jul 1 13:36:57 2020 -0700

    html-preview: use json.dumps() for markup conversion
    
    Certainly better for most scenarios. May need further tweaking by someone
    who cares enough to track down what marked.js is doing.
    
    Fixes #1244

 src/plugins/html-preview/html_preview.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/src/plugins/html-preview/html_preview.py b/src/plugins/html-preview/html_preview.py
index 4f072d59b..f6c3e31ce 100644
--- a/src/plugins/html-preview/html_preview.py
+++ b/src/plugins/html-preview/html_preview.py
@@ -21,8 +21,8 @@
 
 import builtins
 import gi
-import html
 import io
+import json
 import locale
 import os
 import shutil
@@ -435,7 +435,7 @@ class HtmlPreviewPage(Ide.Page):
 
     def get_markdown(self, text):
         params = (HtmlPreviewData.MARKDOWN_CSS.get_data().decode('UTF-8'),
-                  html.escape(text).replace('\n', '\\n'),
+                  json.dumps(text),
                   HtmlPreviewData.MARKED_JS.get_data().decode('UTF-8'),
                   HtmlPreviewData.MARKDOWN_VIEW_JS.get_data().decode('UTF-8'))
 
@@ -443,7 +443,7 @@ class HtmlPreviewPage(Ide.Page):
 <html>
  <head>
   <style>%s</style>
-  <script>var str="%s";</script>
+  <script>var str=%s;</script>
   <script>%s</script>
   <script>%s</script>
  </head>
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]