[orca] Don't ignore caret-moved events for non-navigable text in the case of fragments
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] Don't ignore caret-moved events for non-navigable text in the case of fragments
- Date: Thu, 30 Jan 2020 23:32:10 +0000 (UTC)
commit 7af42aa71d25b62f9d10b5a35094b42a251d99f6
Author: Joanmarie Diggs <joanmarie diggs gmail com>
Date: Thu Jan 30 18:30:12 2020 -0500
Don't ignore caret-moved events for non-navigable text in the case of fragments
Sometimes fragments start with non-navigable text. We need to update our
stored position when this happens.
src/orca/scripts/web/script.py | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
---
diff --git a/src/orca/scripts/web/script.py b/src/orca/scripts/web/script.py
index 58e81ae63..2717cb653 100644
--- a/src/orca/scripts/web/script.py
+++ b/src/orca/scripts/web/script.py
@@ -1476,11 +1476,6 @@ class Script(default.Script):
debug.println(debug.LEVEL_INFO, msg, True)
return True
- if self.utilities.textEventIsForNonNavigableTextObject(event):
- msg = "WEB: Event ignored: Event source is non-navigable text object"
- debug.println(debug.LEVEL_INFO, msg, True)
- return True
-
if self.utilities.textEventIsDueToInsertion(event):
msg = "WEB: Event handled: Updating position due to insertion"
debug.println(debug.LEVEL_INFO, msg, True)
@@ -1496,6 +1491,13 @@ class Script(default.Script):
orca.setLocusOfFocus(event, obj)
return True
+ # We want to do this check after the same-page-fragment check because some
+ # fragments start with non-navigable text objects.
+ if self.utilities.textEventIsForNonNavigableTextObject(event):
+ msg = "WEB: Event ignored: Event source is non-navigable text object"
+ debug.println(debug.LEVEL_INFO, msg, True)
+ return True
+
if self.utilities.lastInputEventWasPageNav() \
and not self.utilities.isLink(event.source) \
and not event.source.getRole() == pyatspi.ROLE_COMBO_BOX:
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]