[gnome-software] source selector: Fix vertical alignment of widgets.



commit 34ad12bf56f7ca871996fe30122705ba6f295768
Author: Robert Ancell <robert ancell canonical com>
Date:   Wed Jan 29 09:51:17 2020 +1300

    source selector: Fix vertical alignment of widgets.
    
    Stop widgets from expanding vertically and instead set the vertical alignment of
    the grid which resolves the reason they were set to expand.
    
    The existing code was observed causing the header bar to vertically expand,
    which may have been an issue in that particular version of GTK. The fix is still
    applicable as these widgets should never expand vertically.

 src/gnome-software.ui | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
---
diff --git a/src/gnome-software.ui b/src/gnome-software.ui
index cb0db967..decb44e0 100644
--- a/src/gnome-software.ui
+++ b/src/gnome-software.ui
@@ -275,7 +275,6 @@
                   <object class="GtkLabel">
                     <property name="label" translatable="yes" comments="Translators: This is a label in the 
header bar, followed by a drop down to choose between different source repos">Source</property>
                     <property name="valign">GTK_ALIGN_CENTER</property>
-                    <property name="vexpand">1</property>
                     <property name="visible">1</property>
                     <style>
                       <class name="dim-label"/>
@@ -292,11 +291,11 @@
                       <object class="GtkGrid">
                         <property name="column-spacing">12</property>
                         <property name="visible">1</property>
+                        <property name="valign">GTK_ALIGN_CENTER</property>
                         <child>
                           <object class="GtkLabel" id="origin_button_label">
                             <property name="label"></property>
                             <property name="valign">GTK_ALIGN_CENTER</property>
-                            <property name="vexpand">1</property>
                             <property name="visible">1</property>
                             <property name="xalign">0</property>
                             <property name="width_chars">10</property>
@@ -307,7 +306,6 @@
                             <property name="icon-name">pan-down-symbolic</property>
                             <property name="pixel-size">16</property>
                             <property name="valign">GTK_ALIGN_CENTER</property>
-                            <property name="vexpand">1</property>
                             <property name="visible">1</property>
                           </object>
                         </child>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]